Bug 154138 - EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should be called EditableRoot instead
Summary: EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-11 16:22 PST by Beth Dakin
Modified: 2016-02-12 10:53 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.95 KB, patch)
2016-02-11 16:24 PST, Beth Dakin
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-02-11 16:22:19 PST
EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should be called EditableRoot instead
Comment 1 Beth Dakin 2016-02-11 16:24:22 PST
Created attachment 271102 [details]
Patch

This is kind of a rubber-stamp situation, but I thought I would post a patch anyway.
Comment 2 Beth Dakin 2016-02-11 16:32:21 PST
Thanks Alexey! http://trac.webkit.org/changeset/196456
Comment 3 Darin Adler 2016-02-11 17:39:04 PST
Comment on attachment 271102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271102&action=review

> Source/WebKit/mac/WebView/WebFrameInternal.h:66
>  enum class NSRangeIsRelativeTo : uint8_t {

Is it really OK for us to have something that happens to use the NS prefix? I think that’s recipe for conflict with AppKit and Foundation!
Comment 4 Beth Dakin 2016-02-12 10:47:05 PST
(In reply to comment #3)
> Comment on attachment 271102 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271102&action=review
> 
> > Source/WebKit/mac/WebView/WebFrameInternal.h:66
> >  enum class NSRangeIsRelativeTo : uint8_t {
> 
> Is it really OK for us to have something that happens to use the NS prefix?
> I think that’s recipe for conflict with AppKit and Foundation!

That is very true. I will re-name.
Comment 5 Beth Dakin 2016-02-12 10:53:39 PST
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 271102 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=271102&action=review
> > 
> > > Source/WebKit/mac/WebView/WebFrameInternal.h:66
> > >  enum class NSRangeIsRelativeTo : uint8_t {
> > 
> > Is it really OK for us to have something that happens to use the NS prefix?
> > I think that’s recipe for conflict with AppKit and Foundation!
> 
> That is very true. I will re-name.

I posted a re-name here: https://bugs.webkit.org/show_bug.cgi?id=154174