Bug 154138 – EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should be called EditableRoot instead

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Beth Dakin]

EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should be called EditableRoot instead

[Beth Dakin]

Created attachment 271102 [details]
Patch

This is kind of a rubber-stamp situation, but I thought I would post a patch anyway.

[Beth Dakin]

Thanks Alexey! http://trac.webkit.org/changeset/196456

[Darin Adler]

Comment on attachment 271102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271102&action=review

> Source/WebKit/mac/WebView/WebFrameInternal.h:66
>  enum class NSRangeIsRelativeTo : uint8_t {

Is it really OK for us to have something that happens to use the NS prefix? I think that’s recipe for conflict with AppKit and Foundation!

[Beth Dakin]

(In reply to comment #3)
> Comment on attachment 271102 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271102&action=review
> 
> > Source/WebKit/mac/WebView/WebFrameInternal.h:66
> >  enum class NSRangeIsRelativeTo : uint8_t {
> 
> Is it really OK for us to have something that happens to use the NS prefix?
> I think that’s recipe for conflict with AppKit and Foundation!

That is very true. I will re-name.

[Beth Dakin]

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 271102 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=271102&action=review
> > 
> > > Source/WebKit/mac/WebView/WebFrameInternal.h:66
> > >  enum class NSRangeIsRelativeTo : uint8_t {
> > 
> > Is it really OK for us to have something that happens to use the NS prefix?
> > I think that’s recipe for conflict with AppKit and Foundation!
> 
> That is very true. I will re-name.

I posted a re-name here: https://bugs.webkit.org/show_bug.cgi?id=154174