Bug 154010
Summary: | Evals that use TDZ should be cacheable in the CodeCache | ||
---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ggaren |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 154002 | ||
Bug Blocks: |
Filip Pizlo
And we should have benchmarks for this.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
This was fixed and benchmarked in <https://bugs.webkit.org/show_bug.cgi?id=164357>.
(Instead of making TDZ evals cacheable in the CodeCache, that patch made them cacheable in the EvalCodeCache. The performance result is even better since the EvalCodeCache caches machine code.)