Bug 154002

Summary: CodeCache should give up on evals if there are variables under TDZ
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 154010    
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2016-02-08 12:35:42 PST
This is pretty sad, and it's another reason why we should not have used a separate check_tdz opcode to check TDZ of scoped variable loads.
Attachments
the patch (2.39 KB, patch)
2016-02-08 12:43 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-02-08 12:43:14 PST
Created attachment 270875 [details] the patch
Mark Lam
Comment 2 2016-02-08 12:46:59 PST
Comment on attachment 270875 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270875&action=review r=me > Source/JavaScriptCore/ChangeLog:16 > + compilersm and caches can see the intended meaning of the bytecode more easily. typo: compilersm ==> compilers
Filip Pizlo
Comment 3 2016-02-08 14:35:54 PST
Landed in http://trac.webkit.org/changeset/196272
Note You need to log in before you can comment on or make changes to this bug.