Bug 153710

Summary: [iOS] WebKit1 apps crash in ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, bfulgham, cdumez, commit-queue, darin, japhet, kling, psolanki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137495    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2016-01-30 09:25:39 PST
WebKit1 apps crash in ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1 on the main thread in iOS.

This is because ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1 is being run on the main thread, creating a race condition where the DiskCacheMonitor object can be deleted after the CFCachedURLResponseCallBackBlock grabs its pointer to use on the WebThread.
Comment 1 David Kilzer (:ddkilzer) 2016-01-30 09:26:01 PST
<rdar://problem/23116706>
Comment 2 David Kilzer (:ddkilzer) 2016-01-30 09:53:04 PST
Created attachment 270308 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-01-30 11:23:04 PST
Comment on attachment 270308 [details]
Patch v1

Clearing flags on attachment: 270308

Committed r195900: <http://trac.webkit.org/changeset/195900>
Comment 4 WebKit Commit Bot 2016-01-30 11:23:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2016-01-30 14:19:21 PST
That's a very nice bit of detective work!