Bug 153677

Summary:

Merge DOMTokenList and DOMSettableTokenList

Product:

WebKit

Reporter:

Simon Pieters (:zcorpan) <zcorpan>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cdumez, commit-queue, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

153831, 153832, 153875

Bug Blocks:

Attachments:

Description	Flags
WIP Patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
WIP Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Patch	none
Patch	none

Simon Pieters (:zcorpan)

Reported 2016-01-29 15:10:18 PST

Implement this spec change: https://github.com/whatwg/dom/pull/120 https://github.com/whatwg/html/issues/361 Tests: https://github.com/w3c/web-platform-tests/pull/2522

Attachments
WIP Patch (34.01 KB, patch) 2016-01-31 14:05 PST, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (881.65 KB, application/zip) 2016-01-31 15:02 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (759.40 KB, application/zip) 2016-01-31 15:06 PST, Build Bot	no flags	Details
WIP Patch (34.39 KB, patch) 2016-01-31 21:30 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (740.51 KB, application/zip) 2016-01-31 22:28 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (788.16 KB, application/zip) 2016-01-31 22:32 PST, Build Bot	no flags	Details
Patch (48.39 KB, patch) 2016-02-03 17:13 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (48.27 KB, patch) 2016-02-04 08:56 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-01-29 15:40:06 PST

<rdar://problem/24419675>

Chris Dumez

Comment 2 2016-01-31 12:48:53 PST

I am in favor of this change but I think we should wait for [1] to be merged before making this change. [1] https://github.com/w3c/web-platform-tests/pull/2522

Chris Dumez

Comment 3 2016-01-31 14:05:20 PST

Created attachment 270346 [details] WIP Patch WIP Patch. Waiting for the web-platform-tests to be updated upstream and re-synced to our repo.

WebKit Commit Bot

Comment 4 2016-01-31 14:06:49 PST

Attachment 270346 [details] did not pass style-queue: ERROR: Source/WebCore/page/DOMWindow.cpp:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2016-01-31 15:02:26 PST

Comment on attachment 270346 [details] WIP Patch Attachment 270346 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/765178 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html

Build Bot

Comment 6 2016-01-31 15:02:30 PST

Created attachment 270347 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-01-31 15:06:10 PST

Comment on attachment 270346 [details] WIP Patch Attachment 270346 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/765179 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html

Build Bot

Comment 8 2016-01-31 15:06:14 PST

Created attachment 270348 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Chris Dumez

Comment 9 2016-01-31 21:30:19 PST

Created attachment 270372 [details] WIP Patch

Build Bot

Comment 10 2016-01-31 22:28:21 PST

Comment on attachment 270372 [details] WIP Patch Attachment 270372 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/766495 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html

Build Bot

Comment 11 2016-01-31 22:28:24 PST

Created attachment 270376 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-01-31 22:32:23 PST

Comment on attachment 270372 [details] WIP Patch Attachment 270372 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/766496 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html

Build Bot

Comment 13 2016-01-31 22:32:28 PST

Created attachment 270377 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Simon Pieters (:zcorpan)

Comment 14 2016-02-03 02:03:40 PST

FYI https://github.com/w3c/web-platform-tests/pull/2522 has now been merged.

Chris Dumez

Comment 15 2016-02-03 07:36:06 PST

(In reply to comment #14) > FYI https://github.com/w3c/web-platform-tests/pull/2522 has now been merged. (In reply to comment #14) > FYI https://github.com/w3c/web-platform-tests/pull/2522 has now been merged. Great, thanks for letting me know. I will update the patch.

Chris Dumez

Comment 16 2016-02-03 17:13:12 PST

Created attachment 270614 [details] Patch

WebKit Commit Bot

Comment 17 2016-02-03 22:44:09 PST

Comment on attachment 270614 [details] Patch Rejecting attachment 270614 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 270614, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 2ab958f..d736222 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 196108 = 2ab958fe28f99e10dfef134913fe6f90ccc8f0e6 r196109 = d736222b61e288503672c3b786cfd27b51921165 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/780256

Chris Dumez

Comment 18 2016-02-04 08:56:28 PST

Created attachment 270660 [details] Patch

Chris Dumez

Comment 19 2016-02-04 08:57:48 PST

Comment on attachment 270660 [details] Patch Clearing flags on attachment: 270660 Committed r196123: <http://trac.webkit.org/changeset/196123>

Chris Dumez

Comment 20 2016-02-04 08:57:53 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.