Bug 153421

Summary: Do not convert GlyphBufferAdvance to FloatSize
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mmaxfield, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-01-25 04:08:08 PST
In Qt port we have GlyphBufferAdvance based on point type, not size type, however this code seems to work equally well with both point- and size-based GlyphBufferAdvance.
Attachments
Patch (1.37 KB, patch)
2016-01-25 04:10 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2016-01-25 04:25 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-01-25 04:10:34 PST
Created attachment 269740 [details] Patch
Konstantin Tokarev
Comment 2 2016-01-25 04:25:08 PST
Created attachment 269741 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-01-25 09:00:37 PST
I think it's bad that these platform types propagate around masquerading as cross-platform types.
Konstantin Tokarev
Comment 4 2016-01-25 09:05:24 PST
If you are interested in this kind of patches, could you help me with SVGGlyphToPathTranslator::extents (rendering/svg/SVGTextRunRenderingContext.cpp)? It has similar issue: mapSize is used to convert width of GlyphBufferAdvance, which is converted to FloatSize for this purpose.
WebKit Commit Bot
Comment 5 2016-01-25 09:49:31 PST
Comment on attachment 269741 [details] Patch Clearing flags on attachment: 269741 Committed r195539: <http://trac.webkit.org/changeset/195539>
WebKit Commit Bot
Comment 6 2016-01-25 09:49:36 PST
All reviewed patches have been landed. Closing bug.
Konstantin Tokarev
Comment 7 2016-01-25 10:59:16 PST
Did not come up with anything more elegant than https://bugs.webkit.org/show_bug.cgi?id=153429
Note You need to log in before you can comment on or make changes to this bug.