| Summary: | Web Inspector: add support for placing Views in DataGrid column headers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 153032 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 269633 [details]
[Patch] Proposed Fix
There are perf issues with this patch. None that I noticed whole ad hoc testing, but as written DataGrid will call offsetWidth many more times that previously, even if no column header cells are hosting Views. Will fix momentarily. Created attachment 269707 [details]
[Patch] Proposed Fix
Comment on attachment 269707 [details] [Patch] Proposed Fix Clearing flags on attachment: 269707 Committed r195522: <http://trac.webkit.org/changeset/195522> All reviewed patches have been landed. Closing bug. |
Created attachment 269628 [details] [Image] OverviewTimelineView with ruler column header * SUMMARY Add support for placing Views in DataGrid column headers. DataGrid already provides a column property `titleDOMFragment` for using custom DOM content in place of simple title text content. The ability to place a TimelineRuler inside a header cell is needed to mix normal grid columns with the "graph only" grid column used in OverviewTimelineView's data grid. See attached screenshot.