Bug 153387

Summary: Web Inspector: add support for placing Views in DataGrid column headers
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 153032    
Attachments:
Description Flags
[Image] OverviewTimelineView with ruler column header
none
[Patch] Proposed Fix
none
[Patch] Proposed Fix none

Matt Baker
Reported 2016-01-22 17:59:31 PST
Created attachment 269628 [details] [Image] OverviewTimelineView with ruler column header * SUMMARY Add support for placing Views in DataGrid column headers. DataGrid already provides a column property `titleDOMFragment` for using custom DOM content in place of simple title text content. The ability to place a TimelineRuler inside a header cell is needed to mix normal grid columns with the "graph only" grid column used in OverviewTimelineView's data grid. See attached screenshot.
Attachments
[Image] OverviewTimelineView with ruler column header (222.49 KB, image/png)
2016-01-22 17:59 PST, Matt Baker 		no flags
Details
[Patch] Proposed Fix (3.05 KB, patch)
2016-01-22 19:39 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (5.60 KB, patch)
2016-01-24 17:04 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-22 17:59:46 PST
<rdar://problem/24310797>
Matt Baker
Comment 2 2016-01-22 19:39:01 PST
Created attachment 269633 [details] [Patch] Proposed Fix
Matt Baker
Comment 3 2016-01-22 19:53:08 PST
There are perf issues with this patch. None that I noticed whole ad hoc testing, but as written DataGrid will call offsetWidth many more times that previously, even if no column header cells are hosting Views. Will fix momentarily.
Matt Baker
Comment 4 2016-01-24 17:04:37 PST
Created attachment 269707 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2016-01-24 20:00:47 PST
Comment on attachment 269707 [details] [Patch] Proposed Fix Clearing flags on attachment: 269707 Committed r195522: <http://trac.webkit.org/changeset/195522>
WebKit Commit Bot
Comment 6 2016-01-24 20:00:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.