Created attachment 269430[details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 269432[details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 269433[details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Remaining issues:
1. multi-col clips outline now that it's part of visual overflow. Non-multi-column nested layer painting works (no clipping) see: fast/multicol/multicol-with-child-renderLayer-for-input.html (and somewhat related: imported/blink/fast/multicol/outlines-at-column-boundaries.html)
2. Have someone fixed that PostResolutionCallbackDisabler issue (not a blocker)
Created attachment 269506[details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 269509[details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 269530[details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 270582[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=270582&action=review
Comments in bug.
> Source/WebCore/rendering/InlineFlowBox.cpp:955
> + if (!lineStyle.hasOutline())
> + return;
You should check lineStyle.outlineSize() too, since outlineWidth() can be positive, but outlineOffset pushes you back in. If outlineSize() == 0, then you don't have overflow, even if outlineWidth() > 0.
> Source/WebCore/rendering/RenderBox.cpp:4496
> + if (!style().boxShadow() && !style().hasBorderImageOutsets() && !outlineStyleForRepaint().hasOutline())
Same problem here. Should check outlineSize().
> Source/WebCore/rendering/RenderBox.cpp:4543
> + if (outlineStyleForRepaint().hasOutline()) {
Same.
> Source/WebCore/rendering/style/RenderStyle.cpp:2034
> + if (outlineStyleIsAuto())
> + return RenderTheme::platformFocusRingWidth();
This does not seem right to me. If outline-style is auto, you are ignoring the actual parsed value of outline width? Won't this cause us not to honor outline width at all?
> Source/WebCore/rendering/style/RenderStyle.h:671
> + float outlineWidth() const;
> + bool hasOutline() const { return outlineStyle() > BHIDDEN && outlineWidth() > 0; }
You might want to make a helper like "bool hasOutlineInVisualOverflow() const { return hasOutline() && outlineSize() > 0; }" and use it in the places I mentioned earlier.
Consider making some tests with negative outline offsets that pull the ring back in.
Created attachment 270635[details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270658[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=270658&action=review
r=me
> Source/WebCore/rendering/style/RenderStyle.cpp:483
> + if (hasOutline() != other.hasOutline()
> + || (hasOutline()
> + && (outlineSize() != other.outlineSize())))
> + return true;
Assuming I understand correctly, and this method should only return true if your visual overflow could change, then couldn't this check be stricter and use hasOutlineInVisualOverflow?
(In reply to comment #34)
> Zalan could you please sanity-check my follow-up in r196235:
> <http://trac.webkit.org/changeset/196235>
>
> Also, this caused bug #153956, any ideas about that?
I was going to ask cfleizach about it since there are some failures on Mac too. Changeset looks good. Thanks for taking care of that.
2016-01-20 21:14 PST, zalan
2016-01-20 21:52 PST, Build Bot
2016-01-20 22:06 PST, Build Bot
2016-01-20 22:16 PST, Build Bot
2016-01-21 14:19 PST, zalan
2016-01-21 14:30 PST, zalan
2016-01-21 15:32 PST, Build Bot
2016-01-21 15:56 PST, Build Bot
2016-01-21 18:21 PST, Build Bot
2016-01-28 13:11 PST, zalan
2016-02-01 13:46 PST, zalan
2016-02-02 15:12 PST, zalan
2016-02-03 10:02 PST, zalan
2016-02-03 21:07 PST, zalan
2016-02-03 21:25 PST, zalan
2016-02-03 22:22 PST, Build Bot
2016-02-04 08:39 PST, zalan