Bug 153071 – [Win] Remove workarounds for fixed bugs in fmod and pow.

• Component: Web Template Framework
• Status: RESOLVED FIXED

WTF has workarounds for bugs in the MSVC implementation of fmod and pow. I believe these have been fixed, and we can remove the workarounds.

Created attachment 268880 [details]
Patch

I have only tested the following code:

    double a = NAN;
    bool isNan = isnan(a);
    double b = 0;
    double res = pow(a, b);

    double x = 3;
    double y = INFINITY;
    bool isInf = isinf(y);
    double result = fmod(x, y);

[Brent Fulgham]

Comment on attachment 268880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268880&action=review

I like this change, but please wait to land for the win EWS to complete.

> Source/WTF/ChangeLog:11
> +        (wtf_atan2):

Please delete this line (you didn't change wtf_atan2), but prepare-ChangeLog thinks you did.

(In reply to comment #3)
> Comment on attachment 268880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268880&action=review
> 
> I like this change, but please wait to land for the win EWS to complete.
> 
> > Source/WTF/ChangeLog:11
> > +        (wtf_atan2):
> 
> Please delete this line (you didn't change wtf_atan2), but prepare-ChangeLog
> thinks you did.

Thanks for reviewing :) I will wait for the win EWS before landing.

Created attachment 268901 [details]
Patch

(In reply to comment #5)
> Created attachment 268901 [details]
> Patch

Trying again, fixed compile error :)

[Brent Fulgham]

Comment on attachment 268901 [details]
Patch

r=me

Committed r195011: <http://trac.webkit.org/changeset/195011>.