Bug 152785

Summary: [mips] Add missing branchAdd32 implementation in macro assembler
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, Jeffrey.li, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add missing branchAdd32 implementation in mips macro assembler msaboff: review+

Julien Brianceau
Reported 2016-01-06 04:24:01 PST
In mips macro assembler, branchAdd32(ResultCondition cond, Address src, RegisterID dest) implementation is missing.
Attachments
Add missing branchAdd32 implementation in mips macro assembler (1.34 KB, patch)
2016-01-06 04:26 PST, Julien Brianceau 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2016-01-06 04:26:33 PST
Created attachment 268366 [details] Add missing branchAdd32 implementation in mips macro assembler Note: already contributed in qtwekbit http://code.qt.io/cgit/qt/qtwebkit.git/commit/?id=946088cf515ec30de586392ec72e4658b86650a4
Michael Saboff
Comment 2 2016-01-06 09:44:55 PST
Comment on attachment 268366 [details] Add missing branchAdd32 implementation in mips macro assembler r=me
Julien Brianceau
Comment 3 2016-01-06 12:57:05 PST
Manually committed r194639: http://trac.webkit.org/changeset/194639
Julien Brianceau
Comment 4 2016-01-16 03:25:21 PST
*** Bug 145247 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.