Summary: | FTL B3 should do the ArithSub binary snippet | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=152708 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 152668 | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2016-01-04 12:10:07 PST
It turns out that the ArithSub DFG/FTL snippets are totally busted even for the simplest of test cases. See: https://bugs.webkit.org/show_bug.cgi?id=152708 Created attachment 268217 [details]
the patch
Created attachment 268218 [details]
the patch
Created attachment 268219 [details]
the patch
Attachment 268219 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7410: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7424: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in http://trac.webkit.org/changeset/194548 |