Bug 152318

Summary: Get rid of WebDatabaseManager, it's been replaced by WebsiteDataStore
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, gyuyoung.kim, hs85.jeong, jh718.park, ljaehun.lim, ossy, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 152460    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Patch
thorton: review+
Patch none

Anders Carlsson
Reported 2015-12-15 17:08:35 PST
Get rid of WebDatabaseManager, it's been replaced by WebsiteDataStore
Attachments
Patch (82.48 KB, patch)
2015-12-15 17:10 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (874.42 KB, application/zip)
2015-12-15 18:07 PST, Build Bot 		no flags
Details
Patch (82.95 KB, patch)
2015-12-16 10:21 PST, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
Patch (2.70 KB, patch)
2015-12-16 11:15 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-12-15 17:10:25 PST
Created attachment 267414 [details] Patch
Build Bot
Comment 2 2015-12-15 18:07:32 PST
Comment on attachment 267414 [details] Patch Attachment 267414 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/564670 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2015-12-15 18:07:34 PST
Created attachment 267415 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Anders Carlsson
Comment 4 2015-12-16 10:21:44 PST
Created attachment 267465 [details] Patch
Csaba Osztrogonác
Comment 5 2015-12-16 11:15:45 PST
Created attachment 267474 [details] Patch cmake buildsystem fix, please integrate it before landing.
Csaba Osztrogonác
Comment 6 2015-12-16 11:17:59 PST
WKDataBaseManager is still used by EFL port, so it will break the build.
Anders Carlsson
Comment 7 2015-12-18 14:27:40 PST
(In reply to comment #6) > WKDataBaseManager is still used by EFL port, so it will break the build. Yup, they're going to have to switch over to WebsiteDataStore. I'll make sure to land your build fix.
Anders Carlsson
Comment 8 2015-12-18 14:35:15 PST
Committed r194295: <http://trac.webkit.org/changeset/194295>
Note You need to log in before you can comment on or make changes to this bug.