Bug 152175

Summary: Modern IDB: storage/indexeddb/index-count.html fails
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150882    
Attachments:
Description Flags
Patch v1 none

Description Brady Eidson 2015-12-11 09:28:03 PST 
Modern IDB: storage/indexeddb/index-count.html fails

This is basically the IDBIndex version of https://bugs.webkit.org/show_bug.cgi?id=152167
Comment 1 Brady Eidson 2015-12-11 09:47:04 PST 
Created attachment 267171 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-12-11 11:14:00 PST 
Comment on attachment 267171 [details]
Patch v1

Clearing flags on attachment: 267171

Committed r193968: <http://trac.webkit.org/changeset/193968>
Comment 3 WebKit Commit Bot 2015-12-11 11:14:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2015-12-11 15:36:15 PST 
Comment on attachment 267171 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=267171&action=review

> Source/WebCore/Modules/indexeddb/client/IDBIndexImpl.cpp:142
> +    return doCount(*context, IDBKeyRangeData::allKeys(), ec);}

I suggest moving the end brace to the next line.
Comment 5 Brady Eidson 2015-12-11 15:55:21 PST 
(In reply to comment #4)
> Comment on attachment 267171 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267171&action=review
> 
> > Source/WebCore/Modules/indexeddb/client/IDBIndexImpl.cpp:142
> > +    return doCount(*context, IDBKeyRangeData::allKeys(), ec);}
> 
> I suggest moving the end brace to the next line.

Yikes!

By saying "I suggest..." you're being too kind. :)

Fixed in https://trac.webkit.org/changeset/193991