Bug 152175 - Modern IDB: storage/indexeddb/index-count.html fails
Summary: Modern IDB: storage/indexeddb/index-count.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 150882
  Show dependency tree / graph
 
Reported: 2015-12-11 09:28 PST by Brady Eidson
Modified: 2015-12-11 15:55 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (5.45 KB, patch)
2015-12-11 09:47 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-12-11 09:28:03 PST 
Modern IDB: storage/indexeddb/index-count.html fails

This is basically the IDBIndex version of https://bugs.webkit.org/show_bug.cgi?id=152167
Comment 1 Brady Eidson 2015-12-11 09:47:04 PST 
Created attachment 267171 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-12-11 11:14:00 PST 
Comment on attachment 267171 [details]
Patch v1

Clearing flags on attachment: 267171

Committed r193968: <http://trac.webkit.org/changeset/193968>
Comment 3 WebKit Commit Bot 2015-12-11 11:14:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2015-12-11 15:36:15 PST 
Comment on attachment 267171 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=267171&action=review

> Source/WebCore/Modules/indexeddb/client/IDBIndexImpl.cpp:142
> +    return doCount(*context, IDBKeyRangeData::allKeys(), ec);}

I suggest moving the end brace to the next line.
Comment 5 Brady Eidson 2015-12-11 15:55:21 PST 
(In reply to comment #4)
> Comment on attachment 267171 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267171&action=review
> 
> > Source/WebCore/Modules/indexeddb/client/IDBIndexImpl.cpp:142
> > +    return doCount(*context, IDBKeyRangeData::allKeys(), ec);}
> 
> I suggest moving the end brace to the next line.

Yikes!

By saying "I suggest..." you're being too kind. :)

Fixed in https://trac.webkit.org/changeset/193991