Bug 151572

Summary: Web Inspector: use Cmd-Option-L and Cmd-Option-R for toggling navigation and details sidebars
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 151237    
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2015-11-23 14:01:07 PST
We currently use Cmd-0 and Cmd-Option-0, but these don't match Safari's shortcuts and conflict with Cmd-0 as "Reset Page Zoom".
Attachments
Proposed Fix (2.96 KB, patch)
2015-11-23 14:03 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-23 14:01:20 PST
<rdar://problem/23650902>
Blaze Burg
Comment 2 2015-11-23 14:03:56 PST
Created attachment 266098 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2015-11-23 18:43:44 PST
Comment on attachment 266098 [details] Proposed Fix Clearing flags on attachment: 266098 Committed r192755: <http://trac.webkit.org/changeset/192755>
WebKit Commit Bot
Comment 4 2015-11-23 18:43:47 PST
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 5 2015-11-27 20:33:22 PST
Command-Option-R toggles responsive design mode in Safari. Now, pressing Command-Option-R once enters responsive design mode. Pressing it again, toggles the right sidebar. https://cloudup.com/c-qJT91xLhK
Blaze Burg
Comment 6 2015-11-28 15:23:39 PST
(In reply to comment #5) > Command-Option-R toggles responsive design mode in Safari. > Now, pressing Command-Option-R once enters responsive design mode. > Pressing it again, toggles the right sidebar. > https://cloudup.com/c-qJT91xLhK This looks like a focus bug. It doesn't reproduce when Inspector has its own window. When inspector is docked and the main page focused, the shortcut opens RDM and focuses the Web Inspector. It should keep focus when changing into or out of RDM. Can you file a radar about this? It isn't clear whether it's a WebKit or Safari bug.
Note You need to log in before you can comment on or make changes to this bug.