Summary: | REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> | ||||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, gyuyoung, gyuyoung.kim, hs85.jeong, lucas.de.marchi, ossy, ryuan.choi | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Renata Hodovan
2015-11-23 09:03:13 PST
This does not seem to reproduce on Mac. Changing platform to EFL for now. This bug looks a regression. Created attachment 266120 [details]
Patch
Comment on attachment 266120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266120&action=review > Tools/MiniBrowser/efl/main.c:2040 > + window_close(window_find_with_elm_window(elm_window)); If we don't use the parameters (user_data, event_info), how about removing them? Created attachment 266121 [details]
Patch
Comment on attachment 266120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266120&action=review >> Tools/MiniBrowser/efl/main.c:2040 >> + window_close(window_find_with_elm_window(elm_window)); > > If we don't use the parameters (user_data, event_info), how about removing them? It is not huge related with this fix though, let's remove unused parameters as well. Created attachment 266124 [details]
Patch
(In reply to comment #4) > Comment on attachment 266120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266120&action=review > > > Tools/MiniBrowser/efl/main.c:2040 > > + window_close(window_find_with_elm_window(elm_window)); > > If we don't use the parameters (user_data, event_info), how about removing > them? EFL MiniBrowser is C, not C++. So we can't omit parameter. http://stackoverflow.com/questions/8776810/parameter-name-omitted-c-vs-c (In reply to comment #8) > (In reply to comment #4) > > Comment on attachment 266120 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=266120&action=review > > > > > Tools/MiniBrowser/efl/main.c:2040 > > > + window_close(window_find_with_elm_window(elm_window)); > > > > If we don't use the parameters (user_data, event_info), how about removing > > them? > > EFL MiniBrowser is C, not C++. So we can't omit parameter. > > http://stackoverflow.com/questions/8776810/parameter-name-omitted-c-vs-c Okay,, I just worry about some warning occur case like as c++. Thanks for the information. Comment on attachment 266124 [details] Patch Clearing flags on attachment: 266124 Committed r192767: <http://trac.webkit.org/changeset/192767> All reviewed patches have been landed. Closing bug. (In reply to comment #11) > All reviewed patches have been landed. Closing bug. Sorry for the late answer. I made a Bug 151934 to fix this regression. |