Bug 151465

Summary: Create correctness tests for binary snippet operators.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 151485    
Bug Blocks:    
Attachments:
Description Flags
proposed patch. ggaren: review+

Mark Lam
Reported 2015-11-19 14:19:50 PST
Implement a common infrastructure for generating and running tests on binary operators. Also refactored the op_add, op_sub, and op_mul tests to be based on this new infrastructure.
Attachments
proposed patch. (51.86 KB, patch)
2015-11-19 14:35 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-11-19 14:35:44 PST
Created attachment 265905 [details] proposed patch.
Geoffrey Garen
Comment 2 2015-11-19 14:39:15 PST
Comment on attachment 265905 [details] proposed patch. r=me
Mark Lam
Comment 3 2015-11-19 15:17:49 PST
Comment on attachment 265905 [details] proposed patch. Cancelling commit. Will land manually.
Mark Lam
Comment 4 2015-11-19 15:32:44 PST
Thanks for the review. Landed in r192664: <http://trac.webkit.org/r192664>.
Note You need to log in before you can comment on or make changes to this bug.