Summary: | REGRESSION(r192599): It made 34 JSC tests crash on ARM Linux | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Critical | CC: | cgarcia, clopez, ggaren, mark.lam, mcatanzaro, ossy, zan |
Priority: | P1 | ||
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 108645, 151415 |
Description
Csaba Osztrogonác
2015-11-19 03:03:52 PST
ah, the forgot the GTK ARM link: - https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/9377 Looks serious enough for a rollout? What do you think, Mark? (In reply to comment #2) > Looks serious enough for a rollout? What do you think, Mark? Generally we don't rollout any JSC patch which cause build failure or test regression on non Apple ports. Can someone run run-javascriptcore-tests manually on ARM, and post an actual crash trace? Thanks. I just finished a release build run on ARMv7 without any issues. I will also do runs with debug builds and ARM64, but I suspect that this issue needs to be debugged on the EFL port. (In reply to comment #5) > I just finished a release build run on ARMv7 without any issues. I will > also do runs with debug builds and ARM64, but I suspect that this issue > needs to be debugged on the EFL port. I take that back. My build did not include the change. Will re-test. (In reply to comment #4) > Can someone run run-javascriptcore-tests manually on ARM, and post an actual > crash trace? Thanks. I tried to generate backtrack on ARMv7, but unfortunately gdb crashes on debug build of JSC. :( But it seems the bug is in the DFG JIT somewhere, because stress/op_sub.js passes with disable DFG, but crashes by default. I had a release backtrace. I don't think if it helps, but who knows. #0 0x00000000 in ?? () (gdb) bt #0 0x00000000 in ?? () #1 0xb6d83d56 in llint_entry () from /home/webkitbuildbot/slaves/efl-thumb2-official/buildslave/efl-linux-armv7-thumb2-release/build/WebKitBuild/Release/lib/libjavascriptcore_efl.so.1 #2 0xb6d83d56 in llint_entry () from /home/webkitbuildbot/slaves/efl-thumb2-official/buildslave/efl-linux-armv7-thumb2-release/build/WebKitBuild/Release/lib/libjavascriptcore_efl.so.1 #3 0xb6d83da0 in llint_entry () from /home/webkitbuildbot/slaves/efl-thumb2-official/buildslave/efl-linux-armv7-thumb2-release/build/WebKitBuild/Release/lib/libjavascriptcore_efl.so.1 #4 0xb6d7ebe0 in vmEntryToJavaScript () from /home/webkitbuildbot/slaves/efl-thumb2-official/buildslave/efl-linux-armv7-thumb2-release/build/WebKitBuild/Release/lib/libjavascriptcore_efl.so.1 #5 0xb6b4956a in JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) () from /home/webkitbuildbot/slaves/efl-thumb2-official/buildslave/efl-linux-armv7-thumb2-release/build/WebKitBuild/Release/lib/libjavascriptcore_efl.so.1 #6 0xdfacb3fc in ?? () Backtrace stopped: previous frame identical to this frame (corrupt stack?) I'll try to create a debug backtrace on AArch64, but I will have time for it only tomorrow morning (in CET timezone). I found one issue in https://bugs.webkit.org/show_bug.cgi?id=151445 which is now fixed. With that fix, I was able to run the JSC tests with a release build of ToT r192631 to completion without any of the failures reported in this bug. Let me know if you're still seeing any failures. (In reply to comment #8) > I found one issue in https://bugs.webkit.org/show_bug.cgi?id=151445 which is > now fixed. With that fix, I was able to run the JSC tests with a release > build of ToT r192631 to completion without any of the failures reported in > this bug. Let me know if you're still seeing any failures. This does fix the problem for me locally, ARMv7 with Thumb2. I'll leave it to Ossy to confirm, and to close the bug. Thanks for the prompt fix. bug151445 fixed all tests, thanks. *** This bug has been marked as a duplicate of bug 151445 *** |