Summary: | Add WebCore namespace for generated bindings for supplemental method calls | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikos Andronikos <nikos.andronikos> | ||||||
Component: | Tools / Tests | Assignee: | Nikos Andronikos <nikos.andronikos> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, cgarcia, commit-queue, lforschler | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Nikos Andronikos
2015-11-18 21:33:51 PST
Created attachment 265845 [details]
Patch
What is the build failure? What does the generated code look like? Is it calling WebCore namespace code from a namespace inside WebCore? I would believe this change is necessary, but I'd like a little more info. Comment on attachment 265845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265845&action=review > Source/WebCore/ChangeLog:3 > + Add WebCore namespace for generated bindings for supplemental method calls Why? (In reply to comment #2) > What is the build failure? What does the generated code look like? Is it > calling WebCore namespace code from a namespace inside WebCore? I would > believe this change is necessary, but I'd like a little more info. The build failure is that the namespace “WebCore::” is missing before the class name. A little background of what I am implementing: I am implementing a partial interface extension to the “Document” interface using "Supplement" (see “Supplementable.h”). The generated code is output into DOMDocument.mm and looks like this: - (DOMDocumentTimeline *)timeline { WebCore::JSMainThreadNullState state; return kit(WTF::getPtr(DocumentAnimation::timeline(IMPL))); } The compiler complains that “DocumentAnimation” cannot be resolved, because “WebCore::” is missing. My fix corrects this by adding the namespace to “DocumentAnimation”. Note: It looks to me like the lack of the WebCore namespace specifier was an oversight by the author of the supplemental interface changes. He seems to have corrected that oversight for GObject (see: https://bugs.webkit.org/show_bug.cgi?id=79293), but not here. I presume no code has been generated that has hit this before. Created attachment 266073 [details]
Patch
(In reply to comment #3) > Comment on attachment 265845 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265845&action=review > > > Source/WebCore/ChangeLog:3 > > + Add WebCore namespace for generated bindings for supplemental method calls > > Why? See updated patch Comment on attachment 266073 [details] Patch Clearing flags on attachment: 266073 Committed r192750: <http://trac.webkit.org/changeset/192750> All reviewed patches have been landed. Closing bug. |