Bug 151424

Summary: Web Inspector: move cookie url matching out of CookieStorageContentView and clean up some code
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 151413, 151408    
Attachments:
Description Flags
Proposed Fix timothy: review+, bburg: commit-queue-

Blaze Burg
Reported 2015-11-18 16:33:25 PST
Factoring this away from behavior changes so the test can be added with the behavior change it tests.
Attachments
Proposed Fix (8.79 KB, patch)
2015-11-18 16:40 PST, Blaze Burg 		timothy: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-18 16:33:48 PST
<rdar://problem/23603756>
Blaze Burg
Comment 2 2015-11-18 16:40:57 PST
Created attachment 265808 [details] Proposed Fix
Timothy Hatcher
Comment 3 2015-11-18 21:01:31 PST
Comment on attachment 265808 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=265808&action=review > Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:50 > + .then((payload) => { One line please. > Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:54 > + .catch((error) => { Ditto. These really looks weird. > Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:159 > + // The main resource isn't always in the list of resources, make sure to add it as a candidate. It never is.
Blaze Burg
Comment 4 2015-11-18 22:27:24 PST
Committed r192614: <http://trac.webkit.org/changeset/192614>
Note You need to log in before you can comment on or make changes to this bug.