| Summary: | Focus ordering should respect slot elements | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
| Component: | UI Events | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, koivisto, kondapallykalyan | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 154630, 154637, 154660, 154769, 157415 | ||||||||||||
| Bug Blocks: | 148695 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ryosuke Niwa
2015-11-17 21:51:23 PST
Created attachment 279015 [details]
Fixes the bug
Comment on attachment 279015 [details] Fixes the bug Attachment 279015 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1329907 New failing tests: fast/shadow-dom/focus-across-details-element.html fast/shadow-dom/focus-navigation-across-slots.html Created attachment 279016 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Created attachment 279032 [details]
Fixed GTK builds
Created attachment 279033 [details]
Fixed test expectation for iOS
Comment on attachment 279033 [details] Fixed test expectation for iOS View in context: https://bugs.webkit.org/attachment.cgi?id=279033&action=review > Source/WebCore/page/FocusController.cpp:148 > + ContainerNode* parent = node.parentNode(); I would use auto* for various Node*s in this patch. r=me Committed r200964: <http://trac.webkit.org/changeset/200964> |