Bug 154637 - Use more references in FocusNavigationScope
Summary: Use more references in FocusNavigationScope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 151379
  Show dependency tree / graph
 
Reported: 2016-02-24 00:38 PST by Ryosuke Niwa
Modified: 2016-02-24 15:37 PST (History)
4 users (show)

See Also:

Attachments
Cleanup (12.88 KB, patch)
2016-02-24 14:40 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Did one more rename (12.81 KB, patch)
2016-02-24 14:45 PST, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-02-24 00:38:22 PST 
Per Darin's review comment in the bug 154630, use more references in FocusNavigationScope.
Comment 1 Ryosuke Niwa 2016-02-24 14:40:57 PST 
Created attachment 272147 [details]
Cleanup
Comment 2 WebKit Commit Bot 2016-02-24 14:43:25 PST 
Attachment 272147 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:20:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2016-02-24 14:45:41 PST 
Created attachment 272148 [details]
Did one more rename
Comment 4 Chris Dumez 2016-02-24 15:17:34 PST 
Comment on attachment 272148 [details]
Did one more rename

View in context: https://bugs.webkit.org/attachment.cgi?id=272148&action=review

r=me

> Source/WebCore/page/FocusController.cpp:170
> +FocusNavigationScope FocusNavigationScope::scopeOwnedByShadowHost(Node& node)

This should even take an Element& in. Casting inside without check is terrible.
Comment 5 Ryosuke Niwa 2016-02-24 15:37:42 PST 
Comment on attachment 272148 [details]
Did one more rename

View in context: https://bugs.webkit.org/attachment.cgi?id=272148&action=review

>> Source/WebCore/page/FocusController.cpp:170
>> +FocusNavigationScope FocusNavigationScope::scopeOwnedByShadowHost(Node& node)
> 
> This should even take an Element& in. Casting inside without check is terrible.

Will fix. Thanks for the review!
Comment 6 Ryosuke Niwa 2016-02-24 15:37:44 PST 
Committed r197055: <http://trac.webkit.org/changeset/197055>