Bug 157415 – Refactor FocusController::findFocusableElementRecursively

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Ryosuke Niwa]

FocusController::findFocusableElementRecursively and FocusController::nextFocusableElement/previousFocusableElement are named backwards.
The former finds a focusable element and the latter two finds a focusable element or a shadow host.

Fix this mess.

[Ryosuke Niwa]

Created attachment 278240 [details]
Cleanup

[Ryosuke Niwa]

Created attachment 278243 [details]
Renamed one more function

[Darin Adler]

Comment on attachment 278243 [details]
Renamed one more function

View in context: https://bugs.webkit.org/attachment.cgi?id=278243&action=review

I am getting lost in all these super-long function names. The new names do seem more accurate and precise.

> Source/WebCore/page/FocusController.cpp:435
> +    while (owner) {

This would be more readable as a for loop, but I guess it’s hard to get outerScope into something visible in the loop condition.

[Ryosuke Niwa]

Thanks for the review!

(In reply to comment #3)
> Comment on attachment 278243 [details]
> Renamed one more function
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278243&action=review
> 
> I am getting lost in all these super-long function names. The new names do
> seem more accurate and precise.

Hopefully next round of cleanup will help.

> > Source/WebCore/page/FocusController.cpp:435
> > +    while (owner) {
> 
> This would be more readable as a for loop, but I guess it’s hard to get
> outerScope into something visible in the loop condition.

Yeah, I thought about the same thing but I didn't want to move FocusNavigationScope out of the loop.

[WebKit Commit Bot]

Comment on attachment 278243 [details]
Renamed one more function

Clearing flags on attachment: 278243

Committed r200576: <http://trac.webkit.org/changeset/200576>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.