Summary: | Modern IDB: Land empty IDBCursor/Index IDL implementations | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | Safari 9 | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 149117 | ||||||||||
Attachments: |
|
Description
Brady Eidson
2015-11-03 09:11:32 PST
Created attachment 264695 [details]
Patch v1
Created attachment 264707 [details]
Patch v2
Attachment 264707 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/indexeddb/client/IDBCursorWithValueImpl.h:26: #ifndef header guard has wrong style, please use: IDBCursorWithValueImpl_h [build/header_guard] [5]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264707 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=264707&action=review Looks mostly good. I'll take a glance at the next patch > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). remove > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.h:42 > + virtual const Deprecated::ScriptValue& key() const override final; new code with deprecated? > Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.cpp:33 > +namespace WebCore { > + > +} // namespace WebCore This file looks pretty exciting so far. > Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h:44 > +private: > + IDBIndexInfo(); how do you make one of these? (In reply to comment #4) > Comment on attachment 264707 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264707&action=review > > Looks mostly good. I'll take a glance at the next patch > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > remove Whoops. > > > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.h:42 > > + virtual const Deprecated::ScriptValue& key() const override final; > > new code with deprecated? > New code implementing old interface. After LegacyIDB is nuked would be a good time to do a sweep of all of that (including the JS bindings, unfortunately) https://bugs.webkit.org/show_bug.cgi?id=150854 for that > > Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.cpp:33 > > +namespace WebCore { > > + > > +} // namespace WebCore > > This file looks pretty exciting so far. It is not! > > > Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h:44 > > +private: > > + IDBIndexInfo(); > > how do you make one of these? In this patch, you do not! Created attachment 264719 [details]
Patch v3
Comment on attachment 264719 [details] Patch v3 Clearing flags on attachment: 264719 Committed r191980: <http://trac.webkit.org/changeset/191980> All reviewed patches have been landed. Closing bug. |