Bug 150821 – Implement text-combine-upright (new version of -webkit-text-combine)

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Myles C. Maxfield]

The name of the property is now "text-combine-upright". In addition, the semantics of this property has changed, where the author is not required to mark up each bit of text they want to make horizontal. Instead, they just put text-combine-upright on the whole paragraph, and we do the right thing.

[Koji Ishii]

> the semantics of this property has changed

It's a bit confusing, sorry about that.

  text-combine-upright: all
is semantically equivalent to
  text-combine: horizontal
so this should be a simple renaming.

  text-combine-upright: digits <integer>?
was added to do automatic detection of digits in a row within a text run as one implementer showed an interest. But this is not implemented by other implementers yet at this point and is at risk. Probably you read this part?

[Ryosuke Niwa]

We should add the support for:
text-combine: digits 2

[yisibl]

Chrome 48 supported it.

[r12a]

Pinging this bug report in the hope that Webkit can finish making the text-combine-upright property work.  

The 'all' value is already supported in Gecko and Blink browsers, and this feature is really important for adequate handling of vertically-set text.

Supporting the 'digits' values would be good for content authors, since it requires less markup, and better semantic markup, and offers greater control.

See https://w3c.github.io/clreq/gap-analysis/#issue249_vertical_text

[Tim Nguyen (:ntim)]

Splitting this in 2 bits makes sense to me:
* Style work: Making -webkit-text-combine inherited, and implement text-combine-upright as an aliased property (with different values)

* Rendering work: Implement "digits" syntax

[Radar WebKit Bug Importer]

<rdar://problem/86913556>

[Tim Nguyen (:ntim)]

Created attachment 448001 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 448002 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 448006 [details]
Patch

[Dean Jackson]

Comment on attachment 448006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448006&action=review

> Source/WebCore/ChangeLog:9
> +        This more or less gets to Chrome parity, though there's quite a bit of work
> +        to match the standard, or even just reach Firefox parity.

Could you expand on this a bit? What still needs to be done? Are there open bugzillas?

[Tim Nguyen (:ntim)]

Created attachment 448111 [details]
Patch

[Tim Nguyen (:ntim)]

Committed r287487 (245622@trunk): <https://commits.webkit.org/245622@trunk>

[r12a]

Any movement on this?  WebKit is now the only remaining major browser not to support this.  It is needed by East Asian and Mongolian content authors to produce the default list styling in vertical text, so it's not really just a nice-to-have.  It will get significant real world use.

By the way, please note that the upright text needs to be centred around the vertical baseline.