Summary: | Implement text-combine-upright (new version of -webkit-text-combine) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||
Component: | Layout and Rendering | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | 50167214, changseok, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, ishida, joepeck, kojii, kondapallykalyan, macpherson, menard, ntim, pdr, rniwa, simon.fraser, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 234704, 234705, 234706, 164510, 234694, 234707, 234761, 234843 | ||||||||||||
Bug Blocks: | 150822, 217522 | ||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2015-11-02 16:06:44 PST
> the semantics of this property has changed
It's a bit confusing, sorry about that.
text-combine-upright: all
is semantically equivalent to
text-combine: horizontal
so this should be a simple renaming.
text-combine-upright: digits <integer>?
was added to do automatic detection of digits in a row within a text run as one implementer showed an interest. But this is not implemented by other implementers yet at this point and is at risk. Probably you read this part?
We should add the support for: text-combine: digits 2 Chrome 48 supported it. Pinging this bug report in the hope that Webkit can finish making the text-combine-upright property work. The 'all' value is already supported in Gecko and Blink browsers, and this feature is really important for adequate handling of vertically-set text. Supporting the 'digits' values would be good for content authors, since it requires less markup, and better semantic markup, and offers greater control. See https://w3c.github.io/clreq/gap-analysis/#issue249_vertical_text Splitting this in 2 bits makes sense to me: * Style work: Making -webkit-text-combine inherited, and implement text-combine-upright as an aliased property (with different values) * Rendering work: Implement "digits" syntax Created attachment 448001 [details]
Patch
Created attachment 448002 [details]
Patch
Created attachment 448006 [details]
Patch
Comment on attachment 448006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448006&action=review > Source/WebCore/ChangeLog:9 > + This more or less gets to Chrome parity, though there's quite a bit of work > + to match the standard, or even just reach Firefox parity. Could you expand on this a bit? What still needs to be done? Are there open bugzillas? Created attachment 448111 [details]
Patch
Committed r287487 (245622@trunk): <https://commits.webkit.org/245622@trunk> |