Bug 150613

Summary:

Rename JSDOMWrapper.impl to JSDOMWrapper.wrapped

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore JavaScript

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Updating mm files	none
Updating mm files	none
Fixing win	none
Fixing IDB	none
Patch for landing	none
Fixing IDBObjectStore	none
Fixing IDBObjectStore	none

Description youenn fablet 2015-10-27 17:08:37 PDT

Following on JSDOMWrapper renaming, we may want to rename impl() and m_impl to wrapped()/m_wrapped, in JSDOMWrapper and related classes.

Comment 1 youenn fablet 2015-10-27 17:15:26 PDT

Created attachment 264177 [details]
Patch

Comment 2 youenn fablet 2015-10-27 17:16:33 PDT

This is a follow-up of bug 150120

Comment 3 youenn fablet 2015-10-27 17:24:55 PDT

Created attachment 264181 [details]
Updating mm files

Comment 4 youenn fablet 2015-10-27 17:41:23 PDT

Created attachment 264184 [details]
Updating mm files

Comment 5 youenn fablet 2015-10-28 23:21:31 PDT

Created attachment 264304 [details]
Fixing win

Comment 6 youenn fablet 2015-10-28 23:52:35 PDT

Created attachment 264305 [details]
Fixing IDB

Comment 7 youenn fablet 2015-11-02 01:38:14 PST

Created attachment 264567 [details]
Patch for landing

Comment 8 youenn fablet 2015-11-02 02:15:48 PST

Created attachment 264571 [details]
Fixing IDBObjectStore

Comment 9 WebKit Commit Bot 2015-11-02 02:50:59 PST

Comment on attachment 264571 [details]
Fixing IDBObjectStore

Rejecting attachment 264571 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 -c /Volumes/Data/EWS/WebKit/Source/WebCore/bindings/js/JSImageConstructor.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSImageConstructor.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSIDBObjectStoreCustom.o bindings/js/JSIDBObjectStoreCustom.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/371271

Comment 10 youenn fablet 2015-11-02 02:54:04 PST

Created attachment 264572 [details]
Fixing IDBObjectStore

Comment 11 WebKit Commit Bot 2015-11-02 03:45:12 PST

Comment on attachment 264572 [details]
Fixing IDBObjectStore

Clearing flags on attachment: 264572

Committed r191887: <http://trac.webkit.org/changeset/191887>

Comment 12 WebKit Commit Bot 2015-11-02 03:45:16 PST

All reviewed patches have been landed.  Closing bug.