Bug 150608

Summary:

Web Inspector: "No Filter Results" message overlaps Debugger sidebar sections

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Overlapping message	none
[Screenshot] Smarter filter message placement	none
[Patch] Proposed Fix	none

Matt Baker

Reported 2015-10-27 15:00:06 PDT

Created attachment 264164 [details] [Image] Overlapping message * SUMMARY No Filter Results message overlaps Debugger sidebar sections. The message element should remain within Scripts details section. * STEPS TO REPRODUCE 1. Inspector -> Debugger tab 2. Force the page to pause in the debugger 3. Enter nonsense filter text so all scripts are filtered => Message overlaps other sidebar sections other than Scripts (Call Stack, Pause Reason)

Attachments
[Image] Overlapping message (381.51 KB, image/png) 2015-10-27 15:00 PDT, Matt Baker	no flags	Details
[Screenshot] Smarter filter message placement (192.90 KB, image/png) 2015-12-18 18:14 PST, Matt Baker	no flags	Details
[Patch] Proposed Fix (35.07 KB, patch) 2015-12-18 18:48 PST, Matt Baker	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-10-27 15:00:31 PDT

<rdar://problem/23284314>

Matt Baker

Comment 2 2015-10-28 13:07:12 PDT

This will require additional logic to handle the three cases involving a filtered tree outline in the navigation sidebar: 1) The tree is a child of the panel's content element. In this case the message needs to be a child of the content area, i.e. the current way we do things. 2) The tree is a descendent of a details section, and other details sections are visible (e.g. Debugger sidebar when paused). In this case the message needs to be a child of the details section to which the tree belongs. 3) The tree is a descendent of a details section, and other details sections are hidden (e.g. Debugger sidebar when not paused). The message should be handled as in case 1.

Matt Baker

Comment 3 2015-12-16 11:58:14 PST

*** Bug 152350 has been marked as a duplicate of this bug. ***

Joseph Pecoraro

Comment 4 2015-12-17 11:48:33 PST

This prevents clicking in the sidebar and it is not obvious why the clicks are not working. This is important to fix.

Timothy Hatcher

Comment 5 2015-12-17 13:43:57 PST

We also might want to add pointer-events: none to these elements to avoid bugs like this. Even though it would still overlap, clicks would work. That way accidental overlaps are not catastrophic.

Matt Baker

Comment 6 2015-12-18 18:14:29 PST

Created attachment 267668 [details] [Screenshot] Smarter filter message placement Filter message containers are now placed at the correct level in the DOM.

Matt Baker

Comment 7 2015-12-18 18:48:38 PST

Created attachment 267675 [details] [Patch] Proposed Fix

Blaze Burg

Comment 8 2015-12-27 19:46:39 PST

Comment on attachment 267675 [details] [Patch] Proposed Fix Great work. I couldn't find any regressions in my testing with the patch applied. Let's try it out when you are ready.

WebKit Commit Bot

Comment 9 2015-12-31 11:17:44 PST

Comment on attachment 267675 [details] [Patch] Proposed Fix Clearing flags on attachment: 267675 Committed r194460: <http://trac.webkit.org/changeset/194460>

WebKit Commit Bot

Comment 10 2015-12-31 11:17:49 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.