Bug 150322

Summary:

Fix the !ENABLE(CSS_GRID_LAYOUT) build after r190840

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, gyuyoung.kim, kling, koivisto, ossy

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149698

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-10-19 03:50:12 PDT

https://trac.webkit.org/changeset/190840 broke the !ENABLE(CSS_GRID_LAYOUT) build:

../../Source/WebCore/html/HTMLDetailsElement.cpp: In function 'const WTF::AtomicString& WebCore::summarySlotName()':
../../Source/WebCore/html/HTMLDetailsElement.cpp:43:52: error: variable 'WTF::NeverDestroyed<WTF::AtomicString> summarySlot' has initializer but incomplete type
../../Source/WebCore/html/HTMLDetailsElement.cpp:45:1: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors

If ENABLE(CSS_GRID_LAYOUT) is true, NeverDestroyed.h is included by one of the header files,
that's why we didn't notice this error previously. We shouldn't depend on this include,
let's include NeverDestroyed.h explicitly, because this cpp needs it.

Comment 1 Csaba Osztrogonác 2015-10-19 03:52:26 PDT

Created attachment 263466 [details]
Patch

Comment 2 WebKit Commit Bot 2015-10-19 09:10:55 PDT

Comment on attachment 263466 [details]
Patch

Clearing flags on attachment: 263466

Committed r191289: <http://trac.webkit.org/changeset/191289>

Comment 3 WebKit Commit Bot 2015-10-19 09:10:59 PDT

All reviewed patches have been landed.  Closing bug.