Bug 150275

Summary: Rename the PICTURE_SIZES flag to CURRENTSRC
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, dino
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Yoav Weiss
Reported 2015-10-17 03:00:37 PDT
Rename the PICTURE_SIZES flag to CURRENTSRC
Attachments
Patch (52.68 KB, patch)
2015-10-17 03:01 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (52.71 KB, patch)
2015-10-17 03:07 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (54.21 KB, patch)
2015-10-19 01:04 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (59.94 KB, patch)
2015-10-20 00:53 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (60.22 KB, patch)
2015-10-20 01:28 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2015-10-17 03:01:46 PDT
Created attachment 263369 [details] Patch
WebKit Commit Bot
Comment 2 2015-10-17 03:03:55 PDT
Attachment 263369 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yoav Weiss
Comment 3 2015-10-17 03:07:18 PDT
Created attachment 263370 [details] Patch
Yoav Weiss
Comment 4 2015-10-17 03:08:11 PDT
As a split from https://bugs.webkit.org/show_bug.cgi?id=150230 this patch renames the PICTURE_SIZES flag into CURRENTSRC (which is the attribute that this flag is used for now).
Yoav Weiss
Comment 5 2015-10-19 01:04:27 PDT
Created attachment 263454 [details] Patch
Dean Jackson
Comment 6 2015-10-19 23:06:33 PDT
Comment on attachment 263454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263454&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:156 > -ENABLE_PICTURE_SIZES = ; > +ENABLE_CURRENTSRC = ; These files are slightly sorted. You should probably move CURRENTSRC to earlier in the list. > Source/cmake/WebKitFeatures.cmake:134 > - WEBKIT_OPTION_DEFINE(ENABLE_PICTURE_SIZES "Toggle sizes attribute support" PRIVATE OFF) > + WEBKIT_OPTION_DEFINE(ENABLE_CURRENTSRC "Toggle currentSrc attribute support" PRIVATE OFF) Same here.
Yoav Weiss
Comment 7 2015-10-20 00:53:39 PDT
Created attachment 263557 [details] Patch
Yoav Weiss
Comment 8 2015-10-20 01:28:11 PDT
Created attachment 263559 [details] Patch
Yoav Weiss
Comment 9 2015-10-20 01:41:14 PDT
Thanks for reviewing! :) Re-sorted these files and some others.
WebKit Commit Bot
Comment 10 2015-10-20 02:50:27 PDT
Comment on attachment 263559 [details] Patch Clearing flags on attachment: 263559 Committed r191334: <http://trac.webkit.org/changeset/191334>
WebKit Commit Bot
Comment 11 2015-10-20 02:50:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.