Bug 150190

Summary: Always enable MASM_PROBE for debug builds.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, fpizlo, ggaren, joepeck, keith_miller, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2015-10-15 14:58:54 PDT
Enabling it only costs some code space, and incurs no performance cost until put to use. Enabling it for debug builds saves us from having to rebuild the world in order to enable it for debugging.
Attachments
the patch. (1.09 KB, patch)
2015-10-15 15:00 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-10-15 15:00:51 PDT
Created attachment 263193 [details] the patch.
Geoffrey Garen
Comment 2 2015-10-15 16:06:42 PDT
Comment on attachment 263193 [details] the patch. Please resolve the namespacing for MASM_PROBE #defines in headers before landing. All macros should have a prefix -- and it looks like you've chosen "PROBE_".
Mark Lam
Comment 3 2015-10-16 12:15:24 PDT
Per our discussion yesterday, the namespacing of MASM_PROBE #defines will not be an issue if they are only local to a .cpp file. In https://bugs.webkit.org/show_bug.cgi?id=150239, I've moved all the of probe implementations from the JITStubs<CPU>.h files to their corresponding MacroAssembler<CPU>.cpp files. Hence, this patch is good for landing now. Thanks.
WebKit Commit Bot
Comment 4 2015-10-16 13:02:59 PDT
Comment on attachment 263193 [details] the patch. Clearing flags on attachment: 263193 Committed r191197: <http://trac.webkit.org/changeset/191197>
WebKit Commit Bot
Comment 5 2015-10-16 13:03:08 PDT
All reviewed patches have been landed. Closing bug.
Mark Lam
Comment 6 2015-10-17 17:28:02 PDT
Follow up landed in r191254: <http://trac.webkit.org/r191254>. This adds CPU(X86) (which was accidentally left out) to the supported list of MASM_PROBE CPUs.
Note You need to log in before you can comment on or make changes to this bug.