Bug 150163

Summary: Binding generator should generate names for JSBuiltins partial interface methods using ImplementedBy value
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore JavaScriptAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149499    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2015-10-15 05:41:18 PDT
To allow JS builtin implementation splitting as done using partial interfaces for WebIDL, the names of the functions used to create the JS builtin functions should be updated.
Attachments
Patch (11.46 KB, patch)
2015-10-15 05:50 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.51 KB, patch)
2015-10-19 02:50 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-10-15 05:50:43 PDT
Created attachment 263146 [details] Patch
youenn fablet
Comment 2 2015-10-15 05:51:31 PDT
Split of bug 149994
youenn fablet
Comment 3 2015-10-15 06:10:28 PDT
(In reply to comment #2) > Split of bug 149994 bug 149499 in fact
Darin Adler
Comment 4 2015-10-18 16:28:41 PDT
Comment on attachment 263146 [details] Patch OK. It’s a little bit sloppy for us to use the smushed together “builtin” as it if’s a word. The phrase is “built in” or possible “built-in”.
youenn fablet
Comment 5 2015-10-19 02:50:51 PDT
Created attachment 263462 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-10-19 03:45:42 PDT
Comment on attachment 263462 [details] Patch for landing Clearing flags on attachment: 263462 Committed r191288: <http://trac.webkit.org/changeset/191288>
WebKit Commit Bot
Comment 7 2015-10-19 03:45:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.