Bug 150113

Summary: CSSKeyframesRule::appendRule is deprecated, but is actually the spec
Product: WebKit Reporter: Ricci Adams <webkit.org>
Component: AnimationsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dino, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mavericks-wk2
none
Archive of layout-test-results from ews100 for mac-mavericks none

Ricci Adams
Reported 2015-10-13 19:28:59 PDT
At the time of this writing, CSS Animations Level 1 has an appendRule() method. This use to be insertRule() (see https://bugs.webkit.org/show_bug.cgi?id=57910). However, a deprecation warning was added for appendRule(), not for insertRule(). https://bugs.webkit.org/show_bug.cgi?id=137532 I believe the deprecation was added to the wrong method. It should be for insertRule(). Right now, I'm getting deprecation warnings when using the standard appendRule().
Attachments
Patch (6.03 KB, patch)
2015-10-15 12:17 PDT, Dean Jackson 		simon.fraser: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (782.78 KB, application/zip)
2015-10-15 12:47 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews100 for mac-mavericks (636.67 KB, application/zip)
2015-10-15 12:50 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-14 08:09:22 PDT
<rdar://problem/23108185>
Dean Jackson
Comment 2 2015-10-15 12:17:25 PDT
Created attachment 263178 [details] Patch
Build Bot
Comment 3 2015-10-15 12:47:25 PDT
Comment on attachment 263178 [details] Patch Attachment 263178 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/292324 New failing tests: http/tests/css/shared-stylesheet-mutation.html http/tests/css/shared-stylesheet-mutation-preconstruct.html
Build Bot
Comment 4 2015-10-15 12:47:28 PDT
Created attachment 263181 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-10-15 12:50:00 PDT
Comment on attachment 263178 [details] Patch Attachment 263178 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/292341 New failing tests: http/tests/css/shared-stylesheet-mutation.html http/tests/css/shared-stylesheet-mutation-preconstruct.html
Build Bot
Comment 6 2015-10-15 12:50:03 PDT
Created attachment 263182 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Dean Jackson
Comment 7 2015-10-15 12:59:02 PDT
Committed r191132: <http://trac.webkit.org/changeset/191132>
Note You need to log in before you can comment on or make changes to this bug.