Bug 150113

Summary:

CSSKeyframesRule::appendRule is deprecated, but is actually the spec

Product:

WebKit

Reporter:

Ricci Adams <webkit.org>

Component:

Animations

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dino, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Archive of layout-test-results from ews100 for mac-mavericks	none

Description Ricci Adams 2015-10-13 19:28:59 PDT

At the time of this writing, CSS Animations Level 1 has an appendRule() method.  This use to be insertRule() (see https://bugs.webkit.org/show_bug.cgi?id=57910).

However, a deprecation warning was added for appendRule(), not for insertRule().  https://bugs.webkit.org/show_bug.cgi?id=137532

I believe the deprecation was added to the wrong method.  It should be for insertRule().  Right now, I'm getting deprecation warnings when using the standard appendRule().

Comment 1 Radar WebKit Bug Importer 2015-10-14 08:09:22 PDT

<rdar://problem/23108185>

Comment 2 Dean Jackson 2015-10-15 12:17:25 PDT

Created attachment 263178 [details]
Patch

Comment 3 Build Bot 2015-10-15 12:47:25 PDT

Comment on attachment 263178 [details]
Patch

Attachment 263178 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/292324

New failing tests:
http/tests/css/shared-stylesheet-mutation.html
http/tests/css/shared-stylesheet-mutation-preconstruct.html

Comment 4 Build Bot 2015-10-15 12:47:28 PDT

Created attachment 263181 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 5 Build Bot 2015-10-15 12:50:00 PDT

Comment on attachment 263178 [details]
Patch

Attachment 263178 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/292341

New failing tests:
http/tests/css/shared-stylesheet-mutation.html
http/tests/css/shared-stylesheet-mutation-preconstruct.html

Comment 6 Build Bot 2015-10-15 12:50:03 PDT

Created attachment 263182 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 7 Dean Jackson 2015-10-15 12:59:02 PDT

Committed r191132: <http://trac.webkit.org/changeset/191132>