Bug 149872

Summary: Binding generated JS constructors should use GlobalObject references
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore JavaScriptAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2015-10-07 00:38:27 PDT
Following on bug 149838, generated JS constructors should manipulate GlobalObject references.
Attachments
Patch (161.27 KB, patch)
2015-10-07 02:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (147.50 KB, patch)
2015-10-07 02:35 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-10-07 02:07:31 PDT
Created attachment 262589 [details] Patch
youenn fablet
Comment 2 2015-10-07 02:35:43 PDT
Created attachment 262590 [details] Patch
WebKit Commit Bot
Comment 3 2015-10-07 02:38:16 PDT
Attachment 262590 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMConstructor.h:45: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 53 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2015-10-08 00:30:56 PDT
Comment on attachment 262590 [details] Patch Clearing flags on attachment: 262590 Committed r190714: <http://trac.webkit.org/changeset/190714>
WebKit Commit Bot
Comment 5 2015-10-08 00:30:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.