Bug 149720

Summary: REGRESSION(r190370): Speedometer spits out an extra console message
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: barraclough, ggaren, msaboff, ossy, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=149621
Attachments:
Description Flags
Screenshot of Mavericks perf bot builds list none

Ryosuke Niwa
Reported 2015-10-01 13:11:54 PDT
run-perf-tests Speedometer fails with the following error message: Running Speedometer/Full.html (1 of 1) ERROR: CONSOLE MESSAGE: line 208: Miss the info bar? Run TodoMVC from a server to avoid a cross-origin error. FAILED Finished: 30.388546 s Either r190370 fixed an existing bug or introduced a new regression.
Attachments
Screenshot of Mavericks perf bot builds list (347.47 KB, image/png)
2015-10-01 13:12 PDT, Ryosuke Niwa 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-10-01 13:12:25 PDT
Created attachment 262280 [details] Screenshot of Mavericks perf bot builds list
Ryosuke Niwa
Comment 2 2015-10-01 13:12:50 PDT
The regression went away when we rolled out the patch so I'm pretty certain this is the culprit.
Ryosuke Niwa
Comment 3 2015-10-02 17:51:02 PDT
Committed r190535: <http://trac.webkit.org/changeset/190535>
Ryosuke Niwa
Comment 4 2015-10-02 17:51:18 PDT
Temporarily ignored this console message.
Csaba Osztrogonác
Comment 5 2015-10-06 02:46:06 PDT
(In reply to comment #4) > Temporarily ignored this console message. I think it is paper overing this serious regression. Why is it good to measure the performace if the test is completely broken?
Csaba Osztrogonác
Comment 6 2015-10-06 02:46:39 PDT
*** This bug has been marked as a duplicate of bug 149621 ***
Ryosuke Niwa
Comment 7 2015-10-06 11:57:41 PDT
(In reply to comment #5) > (In reply to comment #4) > > Temporarily ignored this console message. > > I think it is paper overing this serious regression. Why is it > good to measure the performace if the test is completely broken? I don't think this is a serious regression. Tail optimization does change the JS behavior, and the benchmark isn't failing on the browser. It's just that we have one extra console message when ran inside WRT.
Csaba Osztrogonác
Comment 8 2015-10-06 12:03:27 PDT
(In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #4) > > > Temporarily ignored this console message. > > > > I think it is paper overing this serious regression. Why is it > > good to measure the performace if the test is completely broken? > > I don't think this is a serious regression. Tail optimization does change > the JS behavior, and the benchmark isn't failing on the browser. It's just > that we have one extra console message when ran inside WRT. I don't know the internals of this test. But theoretically I don't think if a JS engine should change the behaviour of any JS script anytime.
Ryosuke Niwa
Comment 9 2015-10-06 12:15:51 PDT
Wait, this isn't a duplicate of 149621.
Radar WebKit Bug Importer
Comment 10 2015-10-06 12:16:08 PDT
<rdar://problem/22995488>
Radar WebKit Bug Importer
Comment 11 2015-10-06 12:16:17 PDT
<rdar://problem/22995494>
Ryosuke Niwa
Comment 12 2015-10-06 12:17:04 PDT
Oh, nvm. I misread it. *** This bug has been marked as a duplicate of bug 149621 ***
Radar WebKit Bug Importer
Comment 13 2015-10-06 12:17:28 PDT
<rdar://problem/22995514>
Note You need to log in before you can comment on or make changes to this bug.