Bug 149594 – [GStreamer] Bump internal jhbuild versions to 1.6.3

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Philippe Normand]

At some point, rather sooner than later :), we should check the tests with the gst 1.6.0 release and bump our jhbuild at least.

Later on we could also remove gst < 1.4.x support (if there's still code with a hard-dependency on this).

[Xabier Rodríguez Calvar]

I added dependency with bug 149580 because before testing anything related to multimedia we need the tests to work.

[Philippe Normand]

(In reply to comment #1)
> I added dependency with bug 149580 because before testing anything related
> to multimedia we need the tests to work.

That doesn't have much to do with GStreamer. Those tests are related with the UserMediaRequest, higher WK2 API level.

[Xabier Rodríguez Calvar]

(In reply to comment #2)
> (In reply to comment #1)
> > I added dependency with bug 149580 because before testing anything related
> > to multimedia we need the tests to work.
> 
> That doesn't have much to do with GStreamer. Those tests are related with
> the UserMediaRequest, higher WK2 API level.

Yeah, read too quick, sorry.

[ChangSeok Oh]

Created attachment 263574 [details]
Patch

[ChangSeok Oh]

(In reply to comment #4)
> Created attachment 263574 [details]
> Patch

@Philip Please feel free to give it r+ when you think it's ready.

[Philippe Normand]

Have you checked the media tests?

[ChangSeok Oh]

(In reply to comment #6)
> Have you checked the media tests?

Yes I have. I could not see any regression for the media tests when I tried.
BTW do we need to update https://trac.webkit.org/browser/trunk/Source/cmake/FindGStreamer.cmake#L88 as well?

[Philippe Normand]

(In reply to comment #7)
> (In reply to comment #6)
> > Have you checked the media tests?
> 
> Yes I have. I could not see any regression for the media tests when I tried.
> BTW do we need to update
> https://trac.webkit.org/browser/trunk/Source/cmake/FindGStreamer.cmake#L88
> as well?

Yes, 1.5.x was a development version.

[Philippe Normand]

Also the EWS build failed. Not sure what's going on there.

[ChangSeok Oh]

Created attachment 263807 [details]
Patch

[ChangSeok Oh]

(In reply to comment #9)
> Also the EWS build failed. Not sure what's going on there.

Maybe it needs a clean build?

[Philippe Normand]

(In reply to comment #11)
> (In reply to comment #9)
> > Also the EWS build failed. Not sure what's going on there.
> 
> Maybe it needs a clean build?

I believe patches touching jhbuild modulesets trigger a full rebuild of the dependencies already on the EWS.

[Philippe Normand]

Ah well ignore me :) It's a clean WebKit build that would be needed here.

[Philippe Normand]

Comment on attachment 263807 [details]
Patch

r=me but please coordinate with the gtk buildbot admins to trigger a clean build when landing this.

[ChangSeok Oh]

(In reply to comment #14)
> Comment on attachment 263807 [details]
> Patch
> 
> r=me but please coordinate with the gtk buildbot admins to trigger a clean
> build when landing this.

Hey. philn thanks for the r+. Would you let me know who are the gtk buildbot admins? Maybe kov and KaL?

[Philippe Normand]

Gustavo & Carlos Lopez, now in CC :)

[Carlos Alberto Lopez Perez]

Regarding the buildbots: Any committer can trigger a clean build, you can login with your trac/wiki webkit credentials in the login form that is available in any bot status page.

For the EWS, just ping me on the IRC (nick: clopez) after landing it and I will trigger a clean build.

[ChangSeok Oh]

(In reply to comment #17)
> Regarding the buildbots: Any committer can trigger a clean build, you can
> login with your trac/wiki webkit credentials in the login form that is
> available in any bot status page.
> 
> For the EWS, just ping me on the IRC (nick: clopez) after landing it and I
> will trigger a clean build.

Good to know. Thanks. Here we go. =)

[WebKit Commit Bot]

Comment on attachment 263807 [details]
Patch

Clearing flags on attachment: 263807

Committed r191576: <http://trac.webkit.org/changeset/191576>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Philippe Normand]

Reverted r191576 for reason:

broke

Committed r191583: <http://trac.webkit.org/changeset/191583>

[Philippe Normand]

(In reply to comment #21)
> Reverted r191576 for reason:
> 
> broke
> 
> Committed r191583: <http://trac.webkit.org/changeset/191583>

Next time I'll remember to quote the revert message when invoking webkit-patch :P

[Philippe Normand]

Created attachment 271648 [details]
patch

[Michael Catanzaro]

Comment on attachment 271648 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271648&action=review

> LayoutTests/platform/gtk/TestExpectations:647
> +webkit.org/b/154390 http/tests/media/reload-after-dialog.html [ Skip ]

Instead of marking these as Skip, I would mark them as failing instead, that way we'll notice when they start passing.

[Philippe Normand]

Committed r196804: <http://trac.webkit.org/changeset/196804>

[Csaba Osztrogonác]

(In reply to comment #25)
> Committed r196804: <http://trac.webkit.org/changeset/196804>

It broke the build on the 32 bit GTK bot:

../DependenciesGTK/Root/include/gstreamer-1.0/gst/gstelement.h:55:27: fatal error: gst/gstconfig.h: No such file or directory
 #include <gst/gstconfig.h>
                           ^

[Philippe Normand]

(In reply to comment #26)
> (In reply to comment #25)
> > Committed r196804: <http://trac.webkit.org/changeset/196804>
> 
> It broke the build on the 32 bit GTK bot:
> 
> ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gstelement.h:55:27: fatal
> error: gst/gstconfig.h: No such file or directory
>  #include <gst/gstconfig.h>
>                            ^

A clean build is needed. I did it on the other bots but forgot this one. Thanks for letting me know.

[Carlos Alberto Lopez Perez]

(In reply to comment #27)
> (In reply to comment #26)
> > (In reply to comment #25)
> > > Committed r196804: <http://trac.webkit.org/changeset/196804>
> > 
> > It broke the build on the 32 bit GTK bot:
> > 
> > ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gstelement.h:55:27: fatal
> > error: gst/gstconfig.h: No such file or directory
> >  #include <gst/gstconfig.h>
> >                            ^
> 
> A clean build is needed. I did it on the other bots but forgot this one.
> Thanks for letting me know.

Seems you forgot also the GTK+ ARM one? It has been failing to build since then. I have just triggered a clean build now.