Summary: | Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, inspector-bugzilla-changes, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 149284 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Devin Rousso
2015-09-22 17:41:11 PDT
Created attachment 305059 [details]
Patch
Created attachment 305060 [details]
[Image] After Patch is applied
Comment on attachment 305059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305059&action=review > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214 > + valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause")); Show Scope Chain Details Sidebar on pause? Comment on attachment 305059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305059&action=review >> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214 >> + valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause")); > > Show Scope Chain Details Sidebar on pause? Personally I don't like the idea of putting "___ sidebar" in localized strings (it just seems redundant to me). Additionally, this makes the text quite long compared to the rest of the settings labels. I think "Scope Chain" is clear enough. Comment on attachment 305059 [details] Patch Clearing flags on attachment: 305059 Committed r214847: <http://trac.webkit.org/changeset/214847> All reviewed patches have been landed. Closing bug. |