Bug 149487

Summary: Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 149284    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied none

Description Devin Rousso 2015-09-22 17:41:11 PDT
Currently, the default is to only show the scope chain sidebar if it is already visible before the pause.  This should be a setting to auto-open the sidebar on pause.
Comment 1 Radar WebKit Bug Importer 2015-09-22 17:41:36 PDT
<rdar://problem/22812421>
Comment 2 Devin Rousso 2017-03-21 18:30:49 PDT
Created attachment 305059 [details]
Patch
Comment 3 Devin Rousso 2017-03-21 18:31:13 PDT
Created attachment 305060 [details]
[Image] After Patch is applied
Comment 4 Timothy Hatcher 2017-04-03 14:49:21 PDT
Comment on attachment 305059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305059&action=review

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214
> +            valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause"));

Show Scope Chain Details Sidebar on pause?
Comment 5 Devin Rousso 2017-04-03 14:59:20 PDT
Comment on attachment 305059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305059&action=review

>> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214
>> +            valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause"));
> 
> Show Scope Chain Details Sidebar on pause?

Personally I don't like the idea of putting "___ sidebar" in localized strings (it just seems redundant to me).  Additionally, this makes the text quite long compared to the rest of the settings labels.  I think "Scope Chain" is clear enough.
Comment 6 WebKit Commit Bot 2017-04-03 15:10:54 PDT
Comment on attachment 305059 [details]
Patch

Clearing flags on attachment: 305059

Committed r214847: <http://trac.webkit.org/changeset/214847>
Comment 7 WebKit Commit Bot 2017-04-03 15:10:56 PDT
All reviewed patches have been landed.  Closing bug.