Bug 149446

Summary: Split author style code out from DocumentStyleSheetCollection
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149230    
Attachments:
Description Flags
patch
none
patch kling: review+

Description Antti Koivisto 2015-09-21 21:30:37 PDT
Shadow trees may have their own author style. Factor the related code out so we can use it outside document context.
Comment 1 Antti Koivisto 2015-09-22 21:33:16 PDT
Created attachment 261794 [details]
patch
Comment 2 Antti Koivisto 2015-09-22 21:38:28 PDT
The patch is large because copy-moves, not because it changes that much.
Comment 3 Antti Koivisto 2015-09-22 23:55:57 PDT
Created attachment 261800 [details]
patch
Comment 4 WebKit Commit Bot 2015-09-22 23:59:17 PDT
Attachment 261800 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/DOMAllInOne.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2015-09-23 04:31:58 PDT
Comment on attachment 261800 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261800&action=review

r=me

> Source/WebCore/ChangeLog:14
> +        AuthorStyleSheets - author stylesheets and optimization code
> +        ExtensionStyleSheets - user stylesheets, injected author stylesheets, content extension stylesheets

This is a nice split.

> Source/WebCore/dom/AuthorStyleSheets.cpp:65
> +    , m_pendingStylesheets(0)
> +    , m_injectedStyleSheetCacheValid(false)
> +    , m_hadActiveLoadingStylesheet(false)
> +    , m_pendingUpdateType(NoUpdate)
> +    , m_usesFirstLineRules(false)
> +    , m_usesFirstLetterRules(false)
> +    , m_usesRemUnits(false)
> +    , m_usesStyleBasedEditability(false)

You know where we could do all this instead? :)
Comment 6 Antti Koivisto 2015-09-23 08:05:29 PDT
https://webkit.org/b/149446