Bug 149412

Summary: [JS Bindings] prototype.constructor should be writable
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, darin, fpizlo, ggaren, haraken, kling, rniwa, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
URL: https://heycam.github.io/webidl/#interface-prototype-object
See Also: https://bugs.webkit.org/show_bug.cgi?id=153667
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2015-09-21 13:36:08 PDT
prototype.constructor should have the following properties: { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true } as per the Web IDL specification: https://heycam.github.io/webidl/#interface-prototype-object In WebKit, it is currently not writable. It is writable in Firefox.
Attachments
Patch (120.63 KB, patch)
2015-09-21 13:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (190.82 KB, patch)
2016-01-28 20:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (212.80 KB, patch)
2016-01-30 12:59 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-09-21 13:36:32 PDT
rdar://problem/22545096
Chris Dumez
Comment 2 2015-09-21 13:46:39 PDT
Created attachment 261681 [details] Patch
Geoffrey Garen
Comment 3 2015-09-21 13:56:10 PDT
Comment on attachment 261681 [details] Patch r=me
WebKit Commit Bot
Comment 4 2015-09-21 15:39:44 PDT
Comment on attachment 261681 [details] Patch Clearing flags on attachment: 261681 Committed r190085: <http://trac.webkit.org/changeset/190085>
WebKit Commit Bot
Comment 5 2015-09-21 15:39:49 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6 2015-09-23 16:55:55 PDT
Reopening as it was rolled out in <https://trac.webkit.org/r190190> for causing crashes in JSC :( See <rdar://problem/22825602> for more info.
Chris Dumez
Comment 7 2016-01-28 20:29:51 PST
Saam helped me figure out the issue. I'll give this another try.
Chris Dumez
Comment 8 2016-01-28 20:38:57 PST
Created attachment 270175 [details] Patch
Chris Dumez
Comment 9 2016-01-30 12:59:39 PST
Created attachment 270316 [details] Patch
Chris Dumez
Comment 10 2016-01-30 13:01:15 PST
Comment on attachment 270316 [details] Patch Clearing flags on attachment: 270316 Committed r195907: <http://trac.webkit.org/changeset/195907>
Chris Dumez
Comment 11 2016-01-30 13:01:22 PST
All reviewed patches have been landed. Closing bug.
Alexey Shvayka
Comment 12 2021-08-04 17:16:08 PDT
*** Bug 77970 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.