WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 149412
77970
Remove the [ReplaceableConstructor] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77970
Summary
Remove the [ReplaceableConstructor] IDL attribute
Kentaro Hara
Reported
2012-02-07 04:58:42 PST
It would make sense to replace the [ReplaceableConstructor] attribute with "DOMWindow" for the following reasons: - The [ReplaceableConstructor] attribute is used by JSC's DOMWindow.idl only. - CodeGeneratorJS.pm supports the [ReplaceableConstructor] attribute for DOMWindow.idl only (If we use [RepaceableConstructor] in other IDL files, then CodeGeneratorJS.pm dies). - DOMWindow is already handled specially here and there in code generators.
Attachments
Patch
(4.31 KB, patch)
2012-02-07 05:01 PST
,
Kentaro Hara
eric
: review+
haraken
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-02-07 05:01:51 PST
Created
attachment 125820
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-02-07 16:00:00 PST
Comment on
attachment 125820
[details]
Patch Seems reasonable.
Kentaro Hara
Comment 3
2012-02-07 16:02:24 PST
Comment on
attachment 125820
[details]
Patch Eric: Thanks for review. In
bug 77966
, we have been discussing how hard-coded "DOMWindow" in code generators should be removed. Let me commit the patch after that discussion.
Alexey Shvayka
Comment 4
2021-08-04 17:16:08 PDT
[ReplaceableConstructor] was removed in
r190085
, as part of %Interface%.prototype.constructor attributes fix. *** This bug has been marked as a duplicate of
bug 149412
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug