Bug 77970 - Remove the [ReplaceableConstructor] IDL attribute
Summary: Remove the [ReplaceableConstructor] IDL attribute
Status: RESOLVED DUPLICATE of bug 149412
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency tree / graph
 
Reported: 2012-02-07 04:58 PST by Kentaro Hara
Modified: 2021-08-04 17:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2012-02-07 05:01 PST, Kentaro Hara 		eric: review+
haraken: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-07 04:58:42 PST 
It would make sense to replace the [ReplaceableConstructor] attribute with "DOMWindow" for the following reasons:

- The [ReplaceableConstructor] attribute is used by JSC's DOMWindow.idl only.
- CodeGeneratorJS.pm supports the [ReplaceableConstructor] attribute for DOMWindow.idl only (If we use [RepaceableConstructor] in other IDL files, then CodeGeneratorJS.pm dies).
- DOMWindow is already handled specially here and there in code generators.
Comment 1 Kentaro Hara 2012-02-07 05:01:51 PST 
Created attachment 125820 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-07 16:00:00 PST 
Comment on attachment 125820 [details]
Patch

Seems reasonable.
Comment 3 Kentaro Hara 2012-02-07 16:02:24 PST 
Comment on attachment 125820 [details]
Patch

Eric: Thanks for review. In bug 77966, we have been discussing how hard-coded "DOMWindow" in code generators should be removed. Let me commit the patch after that discussion.
Comment 4 Alexey Shvayka 2021-08-04 17:16:08 PDT 
[ReplaceableConstructor] was removed in r190085, as part of %Interface%.prototype.constructor attributes fix.

*** This bug has been marked as a duplicate of bug 149412 ***