Bug 153667 - Move more 'constructor' properties to the prototype
Summary: Move more 'constructor' properties to the prototype
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://heycam.github.io/webidl/#inter...
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2016-01-29 13:30 PST by Chris Dumez
Modified: 2016-01-30 12:10 PST (History)
8 users (show)

See Also:

Attachments
WIP Patch (32.50 KB, patch)
2016-01-29 13:31 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (36.74 KB, patch)
2016-01-29 15:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-01-29 13:30:05 PST 
Move more 'constructor' properties to the prototype. Currently, we keep the 'constructor' on the instance for interfaces that have an indexed / named property getter because our getOwnPropertySlot() implementation used to be wrong for such interfaces.
However, getOwnPropertySlot() should be correct after <https://bugs.webkit.org/show_bug.cgi?id=148092> so we should be able to move the 'constructor' up to the prototype now.
Comment 1 Chris Dumez 2016-01-29 13:31:15 PST 
Created attachment 270248 [details]
WIP Patch
Comment 2 Chris Dumez 2016-01-29 15:53:08 PST 
Created attachment 270268 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2016-01-29 15:56:46 PST 
<rdar://problem/24420095>
Comment 4 Radar WebKit Bug Importer 2016-01-29 15:57:05 PST 
<rdar://problem/24420103>
Comment 5 Chris Dumez 2016-01-30 12:10:25 PST 
Comment on attachment 270268 [details]
Patch

Clearing flags on attachment: 270268

Committed r195904: <http://trac.webkit.org/changeset/195904>
Comment 6 Chris Dumez 2016-01-30 12:10:31 PST 
All reviewed patches have been landed.  Closing bug.