WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153667
Move more 'constructor' properties to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153667
Summary
Move more 'constructor' properties to the prototype
Chris Dumez
Reported
2016-01-29 13:30:05 PST
Move more 'constructor' properties to the prototype. Currently, we keep the 'constructor' on the instance for interfaces that have an indexed / named property getter because our getOwnPropertySlot() implementation used to be wrong for such interfaces. However, getOwnPropertySlot() should be correct after <
https://bugs.webkit.org/show_bug.cgi?id=148092
> so we should be able to move the 'constructor' up to the prototype now.
Attachments
WIP Patch
(32.50 KB, patch)
2016-01-29 13:31 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(36.74 KB, patch)
2016-01-29 15:53 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-01-29 13:31:15 PST
Created
attachment 270248
[details]
WIP Patch
Chris Dumez
Comment 2
2016-01-29 15:53:08 PST
Created
attachment 270268
[details]
Patch
Radar WebKit Bug Importer
Comment 3
2016-01-29 15:56:46 PST
<
rdar://problem/24420095
>
Radar WebKit Bug Importer
Comment 4
2016-01-29 15:57:05 PST
<
rdar://problem/24420103
>
Chris Dumez
Comment 5
2016-01-30 12:10:25 PST
Comment on
attachment 270268
[details]
Patch Clearing flags on attachment: 270268 Committed
r195904
: <
http://trac.webkit.org/changeset/195904
>
Chris Dumez
Comment 6
2016-01-30 12:10:31 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug