Summary: | [OS X] Update for Xcode 7.0 on Yosemite | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
Component: | New Bugs | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, mitz, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Myles C. Maxfield
2015-09-20 12:24:25 PDT
Created attachment 261610 [details]
Patch
Comment on attachment 261610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261610&action=review > Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:56 > -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 > @property (readonly) NSSpringLoadingHighlight springLoadingHighlight; > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 springLoadingHighlight doesn't exist in NSDraggingInfo before El Capitan, so we shouldn't forward have on previous OS versions. Could you please clarify what the problem is (perhaps e-mail me the full build log)? Are you building for Yosemite using El Capitan SDK? > Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:57 > - (void)resetSpringLoading; Whatever we do, springLoadingHighlight and resetSpringLoading should be handled uniformly. Created attachment 261664 [details]
proposed fix
Discussed this with Mitz, who explained that the problem is that Xcode 7 for Yosemite ships with 10.11 SDK.
Comment on attachment 261664 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=261664&action=review > Tools/ChangeLog:15 > + dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately). Seems OK for test code. Comment on attachment 261664 [details] proposed fix Clearing flags on attachment: 261664 Committed r190070: <http://trac.webkit.org/changeset/190070> All reviewed patches have been landed. Closing bug. *** Bug 149357 has been marked as a duplicate of this bug. *** |