Bug 149349

Summary: line-break-language-sensitive tests should be marked as flaky
Product: WebKit Reporter: Jake Nielsen <jake.nielsen.webkit>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: commit-queue, mmaxfield
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Marks appropriate tests as flaky.
ap: commit-queue-
Patch two ddkilzer: review-, jake.nielsen.webkit: commit-queue-

Jake Nielsen
Reported 2015-09-18 12:03:29 PDT
More specifically, these four: css3/line-break-language-sensitive/line-break-loose-centered.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-loose-postfixes.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-loose-sound-marks.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-normal-sound-marks.html [ ImageOnlyFailure ]
Attachments
Marks appropriate tests as flaky. (929 bytes, patch)
2015-09-18 12:08 PDT, Jake Nielsen 		ap: commit-queue-
DetailsFormatted DiffDiff
Patch two (1.09 KB, patch)
2015-09-18 13:15 PDT, Jake Nielsen 		ddkilzer: review-
jake.nielsen.webkit: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jake Nielsen
Comment 1 2015-09-18 12:08:46 PDT
Created attachment 261507 [details] Marks appropriate tests as flaky.
Alexey Proskuryakov
Comment 2 2015-09-18 12:13:45 PDT
Comment on attachment 261507 [details] Marks appropriate tests as flaky. View in context: https://bugs.webkit.org/attachment.cgi?id=261507&action=review Looks good to me > TestExpectations:2828 > +# Flaky tests I'd put a comment mentioning bug 149320 here.
Alexey Proskuryakov
Comment 3 2015-09-18 12:14:21 PDT
Comment on attachment 261507 [details] Marks appropriate tests as flaky. Oh wait, this should be in iOS expectations, not in the root. platform/ios-simulator/TestExpectations
Jake Nielsen
Comment 4 2015-09-18 13:13:27 PDT
(In reply to comment #3) > Comment on attachment 261507 [details] > Marks appropriate tests as flaky. > > Oh wait, this should be in iOS expectations, not in the root. > > platform/ios-simulator/TestExpectations Ooops, my bad. I didn't generate the diff from the right directory
Jake Nielsen
Comment 5 2015-09-18 13:15:56 PDT
Created attachment 261516 [details] Patch two
David Kilzer (:ddkilzer)
Comment 6 2015-09-18 13:42:09 PDT
Comment on attachment 261516 [details] Patch two This should really have a ChangeLog.
Myles C. Maxfield
Comment 7 2015-09-18 14:26:33 PDT
For the long term, I should fix these tests instead of leaving them marked as flakey.
Myles C. Maxfield
Comment 8 2015-09-18 14:31:31 PDT
Oh whoops, I misunderstood which tests these are. These tests should only run on particular versions of iOS, and on those versions, they should consistently pass.
Note You need to log in before you can comment on or make changes to this bug.