Bug 149261

Summary:

Web Inspector: The right sidebar always opens up on breakpoint

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Bug Depends on:

149284

Bug Blocks:

Attachments:

Description	Flags
[Image] Current behavior	none
Patch	timothy: review+, joepeck: commit-queue-
Patch	none

Nikita Vasilyev

Reported 2015-09-17 07:09:16 PDT

Created attachment 261391 [details] [Image] Current behavior The right sidebar always opens up when paused on a breakpoint, taking a significant amount of my screen space. Even if I close it, it will open again on a next breakpoint. When execution resumed, the sidebar still stays on, even if it's empty. At very least, we should close the sidebar when resuming execution and there are no watch expressions. I don't think it needs to be open every time since it doesn't even provide essential debugger buttons, e.g. resume, step in, etc. Maybe we should remember if it was closed while paused on debugger and not open it again next time.

Attachments
[Image] Current behavior (314.73 KB, image/png) 2015-09-17 07:09 PDT, Nikita Vasilyev	no flags	Details
Patch (1.42 KB, patch) 2015-09-17 13:18 PDT, Devin Rousso	timothy: review+ joepeck: commit-queue-	Details Formatted Diff Diff
Patch (2.28 KB, patch) 2015-09-22 17:44 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-09-17 07:09:31 PDT

<rdar://problem/22738337>

Timothy Hatcher

Comment 2 2015-09-17 08:42:51 PDT

Matt was wanting to change this too.

Devin Rousso

Comment 3 2015-09-17 13:18:34 PDT

Created attachment 261413 [details] Patch This fixes the issue for me. One quick question though: since I removed the only instance that showScopeChainDetailsSidebarPanel is ever called, should I also remove that function and its corresponding logic or leave it there in case it is needed again?

Joseph Pecoraro

Comment 4 2015-09-17 13:48:54 PDT

Comment on attachment 261413 [details] Patch cq- for now. 1. We think it would be good to add a Preference for this. We should add a FIXME: <webkit.org/b/###> Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause 2. This should remove the "showScopeChainDetailsSidebarPanel" parameter, it is no longer being used. 823:WebInspector.showDebuggerTab = function(breakpointToSelect, showScopeChainDetailsSidebarPanel)

Devin Rousso

Comment 5 2015-09-22 17:44:15 PDT

Created attachment 261785 [details] Patch

WebKit Commit Bot

Comment 6 2015-09-22 18:29:55 PDT

Comment on attachment 261785 [details] Patch Clearing flags on attachment: 261785 Committed r190149: <http://trac.webkit.org/changeset/190149>

WebKit Commit Bot

Comment 7 2015-09-22 18:30:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.