Summary: | Implement scoped styling for shadow DOM | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | koivisto, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 149187, 149353, 149446 | ||||||||
Bug Blocks: | 148695 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2015-09-16 14:13:57 PDT
*** Bug 149328 has been marked as a duplicate of this bug. *** Created attachment 261918 [details]
patch
Created attachment 261939 [details]
patch
Comment on attachment 261939 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=261939&action=review > Source/WebCore/dom/ShadowRoot.cpp:84 > + // We could share style resolver with shadow roots that have identical style. Should this be a FIXME? There is a number of tests in platform/mac/TestExpectations that are marked as being tracked by a duplicate of this bug. Please unmark them if they are expected to pass now: webkit.org/b/149328 fast/shadow-dom/css-scoping-shadow-host-rule.html [ ImageOnlyFailure ] webkit.org/b/149328 fast/shadow-dom/css-scoping-shadow-host-functional-rule.html [ ImageOnlyFailure ] webkit.org/b/149328 fast/shadow-dom/css-scoping-shadow-slotted-rule.html [ ImageOnlyFailure ] webkit.org/b/149328 fast/shadow-dom/css-scoping-shadow-slot-display-override.html [ ImageOnlyFailure ] webkit.org/b/149328 fast/shadow-dom/shadow-layout-after-slot-changes.html [ ImageOnlyFailure ] (In reply to comment #7) > There is a number of tests in platform/mac/TestExpectations that are marked > as being tracked by a duplicate of this bug. Please unmark them if they are > expected to pass now: > > webkit.org/b/149328 fast/shadow-dom/css-scoping-shadow-host-rule.html [ > ImageOnlyFailure ] > webkit.org/b/149328 > fast/shadow-dom/css-scoping-shadow-host-functional-rule.html [ > ImageOnlyFailure ] > webkit.org/b/149328 fast/shadow-dom/css-scoping-shadow-slotted-rule.html [ > ImageOnlyFailure ] > webkit.org/b/149328 > fast/shadow-dom/css-scoping-shadow-slot-display-override.html [ > ImageOnlyFailure ] > webkit.org/b/149328 fast/shadow-dom/shadow-layout-after-slot-changes.html [ > ImageOnlyFailure ] Oh oops, these are tracked by different bugs. Will update soon. Thanks for noticing that. Done that in https://trac.webkit.org/changeset/190275. |