Bug 149114

Summary:

Remove all uses of PassRefPtr in WebCore/xml

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, kangil.han

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

144092

Attachments:

Description	Flags
Patch	none
Patch	none

Description Gyuyoung Kim 2015-09-14 00:40:36 PDT

SSIA

Comment 1 Gyuyoung Kim 2015-09-14 00:45:24 PDT

Created attachment 261107 [details]
Patch

Comment 2 Darin Adler 2015-09-14 18:32:35 PDT

Comment on attachment 261107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261107&action=review

> Source/WebCore/xml/XPathValue.h:47
> +            explicit Value(NodeSet value)

Maybe this should take a NodeSet&&.

> Source/WebCore/xml/XPathValue.h:53
> +            explicit Value(RefPtr<Node> value)

Maybe this should take a RefPtr&&.

> Source/WebCore/xml/XPathValue.h:79
> +                static Ref<Data> create(NodeSet nodeSet) { return adoptRef(*new Data(WTF::move(nodeSet))); }

Maybe this should take a NodeSet&&.

> Source/WebCore/xml/XPathValue.h:90
> +                explicit Data(NodeSet nodeSet)

Maybe this should take a NodeSet&&.

> Source/WebCore/xml/XSLTProcessor.h:47
> +    void setXSLStyleSheet(RefPtr<XSLStyleSheet> styleSheet) { m_stylesheet = WTF::move(styleSheet); }

This should take either a RefPtr&& or just a raw pointer.

Comment 3 Gyuyoung Kim 2015-09-14 20:03:25 PDT

Created attachment 261163 [details]
Patch

Comment 4 Gyuyoung Kim 2015-09-14 21:33:24 PDT

(In reply to comment #2)
> Comment on attachment 261107 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261107&action=review
> 
> > Source/WebCore/xml/XPathValue.h:47
> > +            explicit Value(NodeSet value)
> 
> Maybe this should take a NodeSet&&.
> 
> > Source/WebCore/xml/XPathValue.h:53
> > +            explicit Value(RefPtr<Node> value)
> 
> Maybe this should take a RefPtr&&.
> 
> > Source/WebCore/xml/XPathValue.h:79
> > +                static Ref<Data> create(NodeSet nodeSet) { return adoptRef(*new Data(WTF::move(nodeSet))); }
> 
> Maybe this should take a NodeSet&&.
> 
> > Source/WebCore/xml/XPathValue.h:90
> > +                explicit Data(NodeSet nodeSet)
> 
> Maybe this should take a NodeSet&&.
> 
> > Source/WebCore/xml/XSLTProcessor.h:47
> > +    void setXSLStyleSheet(RefPtr<XSLStyleSheet> styleSheet) { m_stylesheet = WTF::move(styleSheet); }
> 
> This should take either a RefPtr&& or just a raw pointer.

All done. Thanks.

Comment 5 WebKit Commit Bot 2015-09-14 23:01:08 PDT

Comment on attachment 261163 [details]
Patch

Clearing flags on attachment: 261163

Committed r189776: <http://trac.webkit.org/changeset/189776>

Comment 6 WebKit Commit Bot 2015-09-14 23:01:13 PDT

All reviewed patches have been landed.  Closing bug.