| Summary: | Remove all uses of PassRefPtr in crypto, storage, and history | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | New Bugs | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, japhet, kling | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 144092 | ||||||||
| Attachments: |
|
||||||||
|
Description
Gyuyoung Kim
2015-09-12 08:25:34 PDT
Created attachment 261055 [details]
Patch
Comment on attachment 261055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261055&action=review > Source/WebCore/crypto/SubtleCrypto.h:41 > - static PassRefPtr<SubtleCrypto> create(Document& document) { return adoptRef(new SubtleCrypto(document)); } > + static RefPtr<SubtleCrypto> create(Document& document) { return adoptRef(*new SubtleCrypto(document)); } Should return Ref. > Source/WebCore/storage/StorageMap.h:59 > - PassRefPtr<StorageMap> copy(); > + RefPtr<StorageMap> copy(); Should return Ref. Comment on attachment 261055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261055&action=review >> Source/WebCore/crypto/SubtleCrypto.h:41 >> + static RefPtr<SubtleCrypto> create(Document& document) { return adoptRef(*new SubtleCrypto(document)); } > > Should return Ref. Oops. >> Source/WebCore/storage/StorageMap.h:59 >> + RefPtr<StorageMap> copy(); > > Should return Ref. done. Created attachment 261092 [details]
Patch
Comment on attachment 261092 [details] Patch Clearing flags on attachment: 261092 Committed r189675: <http://trac.webkit.org/changeset/189675> All reviewed patches have been landed. Closing bug. *** Bug 141760 has been marked as a duplicate of this bug. *** |