Bug 149059

Summary: Remove all uses of PassRefPtr in WebCore/accessibility and WebCore/fileapi
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch none

Description Gyuyoung Kim 2015-09-11 00:58:18 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-09-11 00:59:57 PDT 
Created attachment 260993 [details]
Patch
Comment 2 Darin Adler 2015-09-11 09:09:11 PDT 
Comment on attachment 260993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260993&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:637
>      ASSERT(referenceRange);

An assertion like this indicates that the argument should be Range&, not Range*.
Comment 3 Gyuyoung Kim 2015-09-11 23:05:10 PDT 
Created attachment 261046 [details]
Patch
Comment 4 Gyuyoung Kim 2015-09-11 23:07:07 PDT 
Comment on attachment 260993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260993&action=review

>> Source/WebCore/accessibility/AccessibilityObject.cpp:637
>>      ASSERT(referenceRange);
> 
> An assertion like this indicates that the argument should be Range&, not Range*.

Yes, right. However referenceRange is already checked in 650 line. So I move it to here instead of the ASSERTION.
Comment 5 Gyuyoung Kim 2015-09-12 00:59:13 PDT 
Comment on attachment 261046 [details]
Patch

EFL EWS looks like false alarm. cq+ed.
Comment 6 WebKit Commit Bot 2015-09-12 01:46:03 PDT 
Comment on attachment 261046 [details]
Patch

Clearing flags on attachment: 261046

Committed r189650: <http://trac.webkit.org/changeset/189650>
Comment 7 WebKit Commit Bot 2015-09-12 01:46:08 PDT 
All reviewed patches have been landed.  Closing bug.