Summary: | [Mac] Add a mock AppleTV device for testing | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||||||||||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, dino, ossy, rniwa, thorton, webkit-bug-importer | ||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||||||
Bug Blocks: | 148958 | ||||||||||||||||||||||||||||
Attachments: |
|
Description
Eric Carlson
2015-09-06 12:27:20 PDT
Created attachment 260713 [details]
Proposed patch.
Attachment 260713 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:32: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2866: Missing space before { [whitespace/braces] [5]
Total errors found: 3 in 49 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 260713 [details] Proposed patch. Attachment 260713 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/146305 New failing tests: media/controls/airplay-picker.html Created attachment 260716 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 260713 [details] Proposed patch. Attachment 260713 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/146327 New failing tests: media/controls/airplay-picker.html Created attachment 260717 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 260719 [details]
Updated patch.
Created attachment 260721 [details]
Updated patch.
Created attachment 260726 [details]
YAUP.
Comment on attachment 260726 [details]
YAUP.
Unofficial r+, but needs a WK2 owner to do a final sign-off.
Comment on attachment 260726 [details] YAUP. View in context: https://bugs.webkit.org/attachment.cgi?id=260726&action=review r+ the WK2 parts, with Jer's r+ for the other bits. > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:2211 > + return decodePlatformData(decoder, target); There's this funny thing where if there's ever a path through a decoder that doesn't write to a field, you can end up with stale data if you re-decode into the same target (which happens on occasion). Please consider clearing the platform data if we're not writing to it, and the others if we're not writing to them. Please unskip media/controls/airplay-picker.html when this is done. Created attachment 265082 [details]
Patch for landing.
Comment on attachment 265082 [details] Patch for landing. Rejecting attachment 265082 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 265082, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 192172 = 7110aaa00b572a4843a3b6327bba8ed9f46da4af r192173 = 3943995b1795d43bb008f0164ea176c68c977fbc r192174 = c4b8e58fb6cf85eaeeeab58749f7a3b5a68849c2 r192175 = 1d8f06915dd20f4bda15034462350931d75ed264 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/407024 Created attachment 265117 [details]
Updated patch for landing.
Comment on attachment 265117 [details] Updated patch for landing. Rejecting attachment 265117 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 265117, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 3. patching file LayoutTests/media/controls/airplay-picker-expected.txt patching file LayoutTests/media/controls/airplay-picker.html patching file LayoutTests/media/controls/controls-test-helpers.js patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1363. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/407599 Created attachment 265133 [details]
One more time?
Comment on attachment 265133 [details] One more time? Rejecting attachment 265133 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 265133, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebKit/mac/WebView/WebViewInternal.h patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/controls/airplay-picker-expected.txt patching file LayoutTests/media/controls/airplay-picker.html patching file LayoutTests/media/controls/controls-test-helpers.js patching file LayoutTests/platform/mac/TestExpectations Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/407939 Created attachment 265134 [details]
Another patch for landing.
Comment on attachment 265134 [details] Another patch for landing. Rejecting attachment 265134 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 265134, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebKit/mac/WebView/WebViewInternal.h patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/controls/airplay-picker-expected.txt patching file LayoutTests/media/controls/airplay-picker.html patching file LayoutTests/media/controls/controls-test-helpers.js patching file LayoutTests/platform/mac/TestExpectations Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/407988 Created attachment 265136 [details]
Another patch for landing.
Comment on attachment 265136 [details] Another patch for landing. Rejecting attachment 265136 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 265136, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebKit/mac/WebView/WebViewInternal.h patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/controls/airplay-picker-expected.txt patching file LayoutTests/media/controls/airplay-picker.html patching file LayoutTests/media/controls/controls-test-helpers.js patching file LayoutTests/platform/mac/TestExpectations Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/408048 Created attachment 265142 [details]
One more time?
Comment on attachment 265142 [details] One more time? Clearing flags on attachment: 265142 Committed r192200: <http://trac.webkit.org/changeset/192200> (In reply to comment #25) > Comment on attachment 265142 [details] > One more time? > > Clearing flags on attachment: 265142 > > Committed r192200: <http://trac.webkit.org/changeset/192200> It broke the build on Apple El Capitan bots: https://build.webkit.org/waterfall (In reply to comment #27) > fixed in http://trac.webkit.org/changeset/192230 Thank you Ossy! |