Bug 148859

Summary: td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159518    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryosuke Niwa
Reported 2015-09-04 17:27:12 PDT
See https://html.spec.whatwg.org/multipage/tables.html#htmltabledatacellelement https://html.spec.whatwg.org/multipage/tables.html#the-th-element td and th elements should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces respectively. This bug was found by the newly added test: LayoutTests/http/tests/w3c/html/semantics/interfaces.html
Attachments
Patch (75.30 KB, patch)
2015-10-16 20:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (75.36 KB, patch)
2015-10-17 11:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (68.42 KB, patch)
2015-10-17 11:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-04 17:28:04 PDT
<rdar://problem/22588664>
Chris Dumez
Comment 2 2015-10-16 16:38:00 PDT
*** Bug 111469 has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 3 2015-10-16 20:42:07 PDT
Created attachment 263357 [details] Patch
Ryosuke Niwa
Comment 4 2015-10-17 10:38:15 PDT
Comment on attachment 263357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263357&action=review > Source/WebCore/html/HTMLTableDataCellElement.idl:27 > + // Legacy. This is legacy in the sense that we're keeping these for WebKit-specific compatibility reasons, right? We should explicitly say that.
Chris Dumez
Comment 5 2015-10-17 10:58:07 PDT
(In reply to comment #4) > Comment on attachment 263357 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263357&action=review > > > Source/WebCore/html/HTMLTableDataCellElement.idl:27 > > + // Legacy. > > This is legacy in the sense that we're keeping these for WebKit-specific > compatibility reasons, right? > We should explicitly say that. Yes, the spec does not have these attributes on HTMLTableDataCellElement but I kept them for backward compatibility. I'll clarify the comment before landing, thanks.
Chris Dumez
Comment 6 2015-10-17 11:33:49 PDT
Created attachment 263379 [details] Patch
WebKit Commit Bot
Comment 7 2015-10-17 11:36:25 PDT
Comment on attachment 263379 [details] Patch Rejecting attachment 263379 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 263379, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: hing file LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt patching file LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt patching file LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt patching file LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/301029
Chris Dumez
Comment 8 2015-10-17 11:50:37 PDT
Created attachment 263381 [details] Patch
WebKit Commit Bot
Comment 9 2015-10-17 12:38:50 PDT
Comment on attachment 263381 [details] Patch Clearing flags on attachment: 263381 Committed r191247: <http://trac.webkit.org/changeset/191247>
WebKit Commit Bot
Comment 10 2015-10-17 12:38:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.