Bug 148844

Summary:

Import a Chromium <input type=color> test

Product:

WebKit

Reporter:

Jon Honeycutt <jhoneycutt>

Component:

Forms

Assignee:

Jon Honeycutt <jhoneycutt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, dbates, wenson_hsieh

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=119094

Attachments:

Description	Flags
Patch	aestes: review+

Description Jon Honeycutt 2015-09-04 16:23:09 PDT

Import a Chromium <input type=color> test that tests that no crash occurs when changing the color with the picker open.

Comment 1 Jon Honeycutt 2015-09-04 16:24:10 PDT

Created attachment 260644 [details]
Patch

Comment 2 Jon Honeycutt 2015-09-04 17:34:13 PDT

Committed r189408: <http://trac.webkit.org/changeset/189408>

Comment 3 Alexey Proskuryakov 2015-09-04 22:32:51 PDT

This test asserts in WebKit1. Will skip for now, but this is really the wrong way to not implement a feature - we should not assert on legitimate code paths.

#if ENABLE(INPUT_TYPE_COLOR)
std::unique_ptr<ColorChooser> WebChromeClient::createColorChooser(ColorChooserClient* client, const Color& initialColor)
{
    // FIXME: Implement <input type='color'> for WK1 (Bug 119094).
    ASSERT_NOT_REACHED();
    return nullptr;
}
#endif